Repository navigation
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:48
ariostas
force-pushed
the
test/enforce-coverage
branch
3 times, most recently
from
November 6, 2026 15:21
12c2405 to
3da3c16
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
|
ariostas
force-pushed
the
test/enforce-coverage
branch
from
November 6, 2026 16:25
3da3c16 to
4c57e39
Compare
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
The test of closing an fsspec source with failing workarounds now checks that both were tried, and the test of splitting XRootD ranges checks the sizes of the vector-read elements. The local HTTP server polls for shutdown every 0.01 s instead of 0.5 s, which every test waited for. The two tests of test_1654 that test_1830_cov_io_futures.py replaces are deleted here. Assisted-by: Claude Code:claude-opus-5-5
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
The ROOT fixture also declared classes and writers that only the tests of scikit-hep#1828 use; if any of them didn't compile with some ROOT version, the tests here would fail too. gErrorIgnoreLevel is now restored if something fails while it's lowered. The four LRUCache tests of test_1661 that test_1832_cov_api_cache.py replaces are deleted here. Assisted-by: Claude Code:claude-opus-5-5
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
The edges of the variable-width axis spanned exactly fXmin to fXmax, so the test couldn't tell the mean of the widths from (fXmax - fXmin) / fNbins. The files that Rewritable opens are now closed after each test. The test of a version 3 TStreamerElement leaves for scikit-hep#1824, which reads its range. Assisted-by: Claude Code:claude-opus-5-5
Extending an RNTuple with lists that are all empty now works, and test_1812 checks it, including that other mismatched types still fail. Assisted-by: Claude Code:claude-opus-5-5
…files Four tests skipped without ROOT before checking anything with uproot; now only their ROOT checks need it. The test of updating a file object closes both files. The test that the first of two branches with the same name was kept leaves for scikit-hep#1827, which rejects such names instead. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
With the tests of the previous PRs, every reachable line and branch is covered. Codecov now requires 100% of the project and of each patch, with branch coverage. Code that can't be reached is marked with "# pragma: no cover (reason)" or "# pragma: no branch (reason)", ends impossible elif chains with "raise AssertionError" (excluded from coverage), or is removed when it was dead, including the dead code that dev/make-models.py generated after unconditional raises. Assisted-by: Claude Code:claude-opus-5-5
scikit-hep#1812 merged after the coverage PRs were split, and two of the ways a chunk with unknown types can mismatch the schema weren't tested: a field of a different kind, and a record with different fields. Assisted-by: Claude Code:claude-opus-5-5
From graphed 0.0.11, session.materialize no longer goes through it for a dataset whose only file lacks the tree, so the test didn't reach the loader's handling of missing trees anymore. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/enforce-coverage
branch
from
November 12, 2026 20:09
4c57e39 to
b68070e
Compare
ariostas
marked this pull request as draft
November 12, 2026 20:20
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
The last PR of the split of #1814, to merge after all the others. Until then, it targets main and contains the commits of the ones still open (#1830–#1833). Its own changes are the last three commits. The main one is "test: enforce 100% line and branch coverage on Codecov":
codecov.ymlrequires 100% of the project and of each patch, andpyproject.tomlturns on branch coverage. Codecov counts the CPU job plus the CUDA 13 GPU job (after_n_builds: 2), since some RNTuple code only runs on the GPU.# pragma: no cover (reason)or# pragma: no branch (reason). Impossibleelifchains end withraise AssertionError(...), which coverage excludes. That exclusion also covers about 30raise AssertionErrorlines that were already insrc/; the review of this PR checked the ones that could matter (the abstract placeholders ofAsContainer,Container,InterpretationandLibrary, the_length_byteschecks, and TBranch basket ranges) and found none reachable.dev/make-models.pygenerated after an unconditional raise. The generator is changed too, so it doesn't come back.AGENTS.mddescribes the coverage rule, and the README gets a coverage badge.The other two commits cover code that changed after the split.
test_1834_cov_rntuple_unknown_types.pycovers two checks from #1812 that reject an RNTuple chunk with unknown types.test_1720_graphed_read.pynow calls the whole-dataset loader ofuproot.grapheddirectly, because from graphed 0.0.11session.materializeno longer goes through it when no file has the tree.With all the PRs below, the full suite has 100% line and branch coverage in a container that mirrors the coverage job (apart from the GPU-only code, which the CUDA job covers).
test/existing-testsby mistake)The fix PRs and #1823 are independent of each other, and the five test PRs only need #1823, which is merged, so they now target main.