Repository navigation
fix: correct errors found while testing file reading and sources - #1825
Merged
Merged
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:47
These were found by the tests of scikit-hep#1814, which are the regression tests here. The fixes are to HTTP and XRootD sources (closing responses, empty requests, readline at the end of a stream), the deflate decompressor, streamer dependencies, TBranch steps inside already-read baskets, paths into RNTuples, files without streamers, cuts that aren't strings, and grouped TBranches in uproot.dask. Assisted-by: Claude Code:claude-opus-5-5
Codecov Report❌ Patch coverage is
Additional details and impacted files
|
ariostas
added a commit
to ariostas/uproot5
that referenced
this pull request
Nov 6, 2026
MET_pt is in one TBasket, so with steps of 15 entries the later steps of a file had nothing to request, and the XRootD source then sent an empty vector read, which failed now and then. scikit-hep#1825 stops sending it; until then, these tests iterate in one step per file. Assisted-by: Claude Code:claude-opus-5-5
ianna
pushed a commit
that referenced
this pull request
Nov 7, 2026
* test: tighten the existing tests and make their fixtures robust Changes to existing tests from #1814 that don't depend on its fixes: they check values instead of only running, restore checks that had been dropped, close the files they open, and run concurrently (each XRootD server has its own admin path and waits until it accepts connections, and reset_classes puts the original model classes back). Assisted-by: Claude Code:claude-opus-5-5 * test: keep the tests that the new coverage tests replace Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in #1829, #1830 and #1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of #1828. Assisted-by: Claude Code:claude-opus-5-5 * test: iterate over XRootD in one step per file MET_pt is in one TBasket, so with steps of 15 entries the later steps of a file had nothing to request, and the XRootD source then sent an empty vector read, which failed now and then. #1825 stops sending it; until then, these tests iterate in one step per file. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Part of the split of #1814 (the list is in #1834). These bugs were found while writing the coverage tests of #1814, and
tests/test_1825_fix_reading.pyholds their regression tests: every test in it fails on main (for parametrized tests, at least one of their cases).ResourceWarnings._ResponseBuffer.readlineno longer loops forever at the end of a stream that has no final newline.arrays/iteratewithin baskets that were already read requests nothing, and the HTTP and XRootD sources return no chunks for no ranges, instead of sending an empty multi-range or vector read.uproot.dask: it reads grouped TBranches, and withlibrary="np"it says why it can't read one.cut: a cut that is neither None nor a string raises aTypeError.deflatepackage doesn't takebufsizeas a keyword.streamer_dependencieskeeps the order of versions.ResourceTrivialExecutorhasnum_workers.