Repository navigation
test: tighten the existing tests and make their fixtures robust - #1823
Merged
Merged
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:47
Changes to existing tests from scikit-hep#1814 that don't depend on its fixes: they check values instead of only running, restore checks that had been dropped, close the files they open, and run concurrently (each XRootD server has its own admin path and waits until it accepts connections, and reset_classes puts the original model classes back). Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/existing-tests
branch
from
November 6, 2026 15:09
c192219 to
5253a21
Compare
Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in scikit-hep#1829, scikit-hep#1830 and scikit-hep#1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of scikit-hep#1828. Assisted-by: Claude Code:claude-opus-5-5
MET_pt is in one TBasket, so with steps of 15 entries the later steps of a file had nothing to request, and the XRootD source then sent an empty vector read, which failed now and then. scikit-hep#1825 stops sending it; until then, these tests iterate in one step per file. Assisted-by: Claude Code:claude-opus-5-5
ianna
approved these changes
Nov 7, 2026
ianna
enabled auto-merge (squash)
November 7, 2026 08:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Part of the split of #1814 (the list is in #1834). These are the changes to existing tests from #1814 that don't depend on any of its fixes: they pass on main. Changes that do depend on a fix are in that fix's PR.
test_0043reads all 14 files again andtest_0603checks delayed opening of local files.test_0927,test_0965, and others).with uproot.open), and repeated tests are parametrized.tests/conftest.py)/tmp/.xrootd.reset_classesputs the original model classes back afterward, the same change as in fix: correct errors found while testing the interpretations #1824.test_1146, which was always skipped because its server requires authentication.The five coverage PRs (listed in #1814) are based on this one. Its branch is also pushed to this repository as
test/existing-tests, so that those PRs show only their own tests.