Repository navigation
test: cover the interpretations - #1829
Merged
ianna merged 2 commits intoNov 12, 2026
Merged
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:47
ariostas
force-pushed
the
test/interpretation-coverage
branch
from
November 6, 2026 15:09
ef53184 to
df3a29d
Compare
ariostas
force-pushed
the
test/existing-tests
branch
from
November 6, 2026 15:10
c192219 to
5253a21
Compare
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
The check that a sequence isn't equal to a string passed for anything but True. The test of Node.__str__ expected its wrong indentation, which scikit-hep#1824 fixes; it is now there, with the right one. The test of Library equality in test_0016 is deleted here, as test_names_and_equality covers it. Assisted-by: Claude Code:claude-opus-5-5
ariostas
added a commit
to ariostas/uproot5
that referenced
this pull request
Nov 6, 2026
Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in scikit-hep#1829, scikit-hep#1830 and scikit-hep#1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of scikit-hep#1828. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/interpretation-coverage
branch
from
November 6, 2026 16:25
df3a29d to
8f105e8
Compare
ianna
pushed a commit
that referenced
this pull request
Nov 7, 2026
* test: tighten the existing tests and make their fixtures robust Changes to existing tests from #1814 that don't depend on its fixes: they check values instead of only running, restore checks that had been dropped, close the files they open, and run concurrently (each XRootD server has its own admin path and waits until it accepts connections, and reset_classes puts the original model classes back). Assisted-by: Claude Code:claude-opus-5-5 * test: keep the tests that the new coverage tests replace Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in #1829, #1830 and #1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of #1828. Assisted-by: Claude Code:claude-opus-5-5 * test: iterate over XRootD in one step per file MET_pt is in one TBasket, so with steps of 15 entries the later steps of a file had nothing to request, and the XRootD source then sent an empty vector read, which failed now and then. #1825 stops sending it; until then, these tests iterate in one step per file. Assisted-by: Claude Code:claude-opus-5-5
Member
Author
|
🤖 AI text below 🤖 This was merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Part of the split of #1814 (the list is in #1834). These are the new tests of #1814 for the interpretations (containers, AwkwardForth, identification, the Python language, libraries, objects and arrays), apart from the regression tests of its fixes, which are in the fix PRs. All of them pass on main.
The base of this PR is
test/existing-tests(#1823). It adds test files and deletestest_library_equality_is_safeoftest_0016, whichtest_names_and_equalityreplaces. Once #1823 is merged, it will be rebased on main.