Repository navigation
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:47
ariostas
force-pushed
the
test/api-coverage
branch
from
November 6, 2026 15:10
a066d67 to
fcab3b9
Compare
ariostas
force-pushed
the
test/existing-tests
branch
from
November 6, 2026 15:10
c192219 to
5253a21
Compare
ariostas
added a commit
to ariostas/uproot5
that referenced
this pull request
Nov 6, 2026
The ROOT fixture also declared writers that only the tests of scikit-hep#1832 use, and if any of them didn't compile with some ROOT version, the tests here would fail too. The fixture also restores gErrorIgnoreLevel if a declaration fails. Assisted-by: Claude Code:claude-opus-5-5
ariostas
added a commit
to ariostas/uproot5
that referenced
this pull request
Nov 6, 2026
Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in scikit-hep#1829, scikit-hep#1830 and scikit-hep#1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of scikit-hep#1828. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/api-coverage
branch
from
November 6, 2026 16:25
fcab3b9 to
d7a7aec
Compare
ianna
pushed a commit
that referenced
this pull request
Nov 7, 2026
* test: tighten the existing tests and make their fixtures robust Changes to existing tests from #1814 that don't depend on its fixes: they check values instead of only running, restore checks that had been dropped, close the files they open, and run concurrently (each XRootD server has its own admin path and waits until it accepts connections, and reset_classes puts the original model classes back). Assisted-by: Claude Code:claude-opus-5-5 * test: keep the tests that the new coverage tests replace Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in #1829, #1830 and #1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of #1828. Assisted-by: Claude Code:claude-opus-5-5 * test: iterate over XRootD in one step per file MET_pt is in one TBasket, so with steps of 15 entries the later steps of a file had nothing to request, and the XRootD source then sent an empty vector read, which failed now and then. #1825 stops sending it; until then, these tests iterate in one step per file. Assisted-by: Claude Code:claude-opus-5-5
ariostas
added a commit
to ariostas/uproot5
that referenced
this pull request
Nov 10, 2026
The ROOT fixture also declared writers that only the tests of scikit-hep#1832 use, and if any of them didn't compile with some ROOT version, the tests here would fail too. The fixture also restores gErrorIgnoreLevel if a declaration fails. Assisted-by: Claude Code:claude-opus-5-5
ariostas
added a commit
that referenced
this pull request
Nov 10, 2026
…1828) * fix: correct errors found while testing RNTuple reading and writing These were found by the tests of #1814, which are the regression tests here. The fixes are to columns of narrower representations (zigzag, delta and truncated or quantized floats), GPU reads of uncompressed and multi-page columns, split columns of unsupported widths, unknown field roles, field paths, linked attribute sets, anchors past 2 GB, and writing empty and masked arrays. Assisted-by: Claude Code:claude-opus-5-5 * test: declare only the C++ that the RNTuple regression tests use The ROOT fixture also declared writers that only the tests of #1832 use, and if any of them didn't compile with some ROOT version, the tests here would fail too. The fixture also restores gErrorIgnoreLevel if a declaration fails. Assisted-by: Claude Code:claude-opus-5-5 * refactor: remove the unused page_is_compressed field of FieldPayload Each page now decides whether it is compressed, and uncompressed pages are recorded as None, so nothing reads the cluster-wide flag anymore. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/api-coverage
branch
from
November 12, 2026 16:02
d7a7aec to
154d667
Compare
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
The ROOT fixture also declared classes and writers that only the tests of scikit-hep#1828 use; if any of them didn't compile with some ROOT version, the tests here would fail too. gErrorIgnoreLevel is now restored if something fails while it's lowered. The four LRUCache tests of test_1661 that test_1832_cov_api_cache.py replaces are deleted here. Assisted-by: Claude Code:claude-opus-5-5
Extending an RNTuple with lists that are all empty now works, and test_1812 checks it, including that other mismatched types still fail. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/api-coverage
branch
from
November 12, 2026 20:00
154d667 to
1a85052
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Part of the split of #1814 (the list is in #1834). These are the new tests of #1814 for the TTree reading API (caches, uproot.dask, graphed reads, read options, TBranch) and the RNTuple reading API, including its NumPy output and files written by ROOT, apart from the regression tests of its fixes, which are in the fix PRs. All of them pass on main.
It adds test files and deletes the four LRUCache tests of
test_1661, whichtest_1832_cov_api_cache.pyreplaces.