Repository navigation
test: cover writing - #1833
Open
ariostas wants to merge 3 commits into
Open
test: cover writing#1833ariostas wants to merge 3 commits into
ariostas wants to merge 3 commits into
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:47
ariostas
force-pushed
the
test/writing-coverage
branch
2 times, most recently
from
November 6, 2026 15:10
faac5bc to
0bb80be
Compare
ariostas
force-pushed
the
test/existing-tests
branch
from
November 6, 2026 15:10
c192219 to
5253a21
Compare
ariostas
force-pushed
the
test/writing-coverage
branch
from
November 6, 2026 16:25
0bb80be to
760bb3f
Compare
ariostas
force-pushed
the
test/writing-coverage
branch
from
November 12, 2026 16:02
760bb3f to
e89da4c
Compare
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
…files Four tests skipped without ROOT before checking anything with uproot; now only their ROOT checks need it. The test of updating a file object closes both files. The test that the first of two branches with the same name was kept leaves for scikit-hep#1827, which rejects such names instead. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/writing-coverage
branch
from
November 12, 2026 20:00
e89da4c to
d8e0f1c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Part of the split of #1814 (the list is in #1834). These are the new tests of #1814 for writing (the cascade, identify, PyROOT conversion, sinks, TGraph, TTrees and writable directories), apart from the regression tests of its fixes, which are in the fix PRs. All of them pass on main.
It only adds test files.