Repository navigation
Conversation
This was referenced Nov 6, 2026
ariostas
marked this pull request as ready for review
November 6, 2026 14:47
ariostas
force-pushed
the
test/io-coverage
branch
from
November 6, 2026 15:09
09cd3c7 to
fb31178
Compare
ariostas
force-pushed
the
test/existing-tests
branch
from
November 6, 2026 15:10
c192219 to
5253a21
Compare
ariostas
added a commit
to ariostas/uproot5
that referenced
this pull request
Nov 6, 2026
Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in scikit-hep#1829, scikit-hep#1830 and scikit-hep#1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of scikit-hep#1828. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/io-coverage
branch
from
November 6, 2026 16:25
fb31178 to
3f9a14d
Compare
ianna
pushed a commit
that referenced
this pull request
Nov 7, 2026
* test: tighten the existing tests and make their fixtures robust Changes to existing tests from #1814 that don't depend on its fixes: they check values instead of only running, restore checks that had been dropped, close the files they open, and run concurrently (each XRootD server has its own admin path and waits until it accepts connections, and reset_classes puts the original model classes back). Assisted-by: Claude Code:claude-opus-5-5 * test: keep the tests that the new coverage tests replace Six tests (of Future.result timeouts, ThreadPoolExecutor.shutdown, the order of LRUCache, and Library equality) were deleted here in favor of tests in #1829, #1830 and #1832, which are based on this PR; until those are merged nothing else would cover them. They are now deleted together with the tests that replace them. A comment no longer points to a file of #1828. Assisted-by: Claude Code:claude-opus-5-5 * test: iterate over XRootD in one step per file MET_pt is in one TBasket, so with steps of 15 entries the later steps of a file had nothing to request, and the XRootD source then sent an empty vector read, which failed now and then. #1825 stops sending it; until then, these tests iterate in one step per file. Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/io-coverage
branch
from
November 12, 2026 16:02
3f9a14d to
3840245
Compare
New tests from scikit-hep#1814, apart from the regression tests of its fixes. Assisted-by: Claude Code:claude-opus-5-5
The test of closing an fsspec source with failing workarounds now checks that both were tried, and the test of splitting XRootD ranges checks the sizes of the vector-read elements. The local HTTP server polls for shutdown every 0.01 s instead of 0.5 s, which every test waited for. The two tests of test_1654 that test_1830_cov_io_futures.py replaces are deleted here. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
ariostas
force-pushed
the
test/io-coverage
branch
from
November 12, 2026 19:59
3840245 to
7bb27e8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Part of the split of #1814 (the list is in #1834). These are the new tests of #1814 for file reading, compression, cursors and chunks, exceptions and extras, file-like objects, fsspec, futures, HTTP, XRootD and utilities, apart from the regression tests of its fixes, which are in the fix PRs. All of them pass on main.
It adds test files and deletes
test_future_result_timeout_raisesandtest_threadpool_shutdown_joins_workersoftest_1654, whichtest_1830_cov_io_futures.pyreplaces.