This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(constants/api): drop 3 dead exports (API_BATCH_REQUEST_LIMIT, SCHEMA_OPERATIONS, API_BASE_URLS dup re-export) - #1014
Merged
Conversation
- API_BATCH_REQUEST_LIMIT — declared in constants/api.ts and re-exported in api/index.ts; zero consumers anywhere in src/server/static-react/. - SCHEMA_OPERATIONS — declared, re-exported from the barrel, and named in schemaClient.ts's import list but never used in the body; no dynamic SCHEMA_OPERATIONS[...] access either. - API_BASE_URLS re-export in constants/api.ts — the sole consumer (ingestionClient.ts) already imports it directly from api/endpoints (the canonical generated source). The barrel api/index.ts doesn't re-export it, so the constants/api.ts re-export was unreachable. Sibling cleanup to #1013 (SCHEMA_ACTION_TYPES); same audit pattern, constants/api.ts was carved out of that PR's scope. Net: pure deletion across 3 files (-19/+2). api/endpoints.ts (canonical API_BASE_URLS) untouched. Verified: npm run typecheck, npm test (788 tests pass). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 12, 2026 04:15
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 12, 2026
SchemaCacheMeta and DefaultSchemaState are used only inside redux.ts (as the type of the `cache` field and the annotation on DEFAULT_SCHEMA_STATE, respectively); the constants barrel doesn't re-export them. Continues the dead-export audit pattern from PRs #1014, #1015, #1016, #1017, and #1018. Interfaces are preserved as file-local typing. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sibling cleanup to #1013 — applies the same dead-export audit pattern to
constants/api.ts, which #1013 explicitly carved out of scope. Pure deletion across 3 files (-19 / +2). No new files, no churn elsewhere.Removed
API_BATCH_REQUEST_LIMIT—constants/api.ts:12+ re-export atapi/index.ts:91. Zero consumers insrc/server/static-react/.SCHEMA_OPERATIONS—constants/api.ts:144-151(6 keys) + re-export atapi/index.ts:100+ dead name inapi/clients/schemaClient.ts:5's multi-name import list (never used in the body, no dynamicSCHEMA_OPERATIONS[...]access either).API_BASE_URLSre-export inconstants/api.ts— theconstants/api.ts:6import from../api/endpoints+ theconstants/api.ts:62re-export. The canonical declaration inapi/endpoints.ts:49(generated from Rust OpenAPI) stays put. The single consumer,api/clients/ingestionClient.ts:2, already imports it directly from../endpoints, so this constants/api.ts re-export was unreachable (api/index.tsdoesn't re-export it).Verified
npm run typecheckclean.npm test— 788 tests pass.git grepconfirms zero hits for all three removed names;API_BASE_URLSremains only in the canonicalendpoints.ts+ its sole consumeringestionClient.ts+ the codegen scriptscripts/generate-endpoints.js.Test plan
🤖 Generated with Claude Code