This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(api/subscription): drop 2 dead exports + unexport 1 internal type - #1023
Merged
Merged
Conversation
… type subscriptionClient.ts exported StorageInfo and getStorageInfo with zero references in the codebase — fully dead. SubscriptionStatus was exported but only mentioned in a doc comment in CloudMigrationSettings.test.tsx (not imported anywhere); kept as a file-local type since it's the return type of the still-exported getSubscriptionStatus. Net diff ~14 lines, single file. Continues #1014/#1015/#1017/#1018/#1022. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 12, 2026 12:15
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
subscriptionClient.tsexportedStorageInfoandgetStorageInfowith zero references in the codebase — fully dead.SubscriptionStatuswas exported but only mentioned in a doc comment inCloudMigrationSettings.test.tsx(not imported anywhere); kept as a file-local type since it's the return type of the still-exportedgetSubscriptionStatus.Continues the dead-export sweep started in #1014 / #1015 / #1017 / #1018 / #1022.
Changes
StorageInfointerface (5 lines)getStorageInfofunction (8 lines)exportkeyword fromSubscriptionStatusinterface — leaves body intactNet diff: ~14 line removals, single file, zero behavior change.
Verified
ts-unused-exportsno longer flagssubscriptionClient.ts.Test plan
npm run typecheckpassesnpm run lintpasses (no new warnings)npm test— 788/788 passnpx ts-unused-exports tsconfig.json | grep subscriptionClient.ts→ clean