This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(constants/ui): drop 2 dead exports + unexport MutationTypeOption - #1015
Merged
Conversation
…tion Follow-up to PR #1014's `constants/api.ts` cleanup, applying the same audit pattern to the sibling `constants/ui.ts`: - Delete `TAB_TRANSITION_DURATION_MS` (was ui.ts:11) — zero consumers. Sibling `FORM_FIELD_DEBOUNCE_MS` under the same banner stays. - Delete `AUTH_INDICATORS` block + banner (was ui.ts:132-137) — zero consumers. - Drop `export` keyword from `MutationTypeOption` interface (was ui.ts:107) — used only inside this file as the type parameter for `MUTATION_TYPES`. Interface body unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 12, 2026 05:17
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 12, 2026
SchemaCacheMeta and DefaultSchemaState are used only inside redux.ts (as the type of the `cache` field and the annotation on DEFAULT_SCHEMA_STATE, respectively); the constants barrel doesn't re-export them. Continues the dead-export audit pattern from PRs #1014, #1015, #1016, #1017, and #1018. Interfaces are preserved as file-local typing. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1014 (the
constants/api.tscleanup) — same audit pattern applied to the siblingconstants/ui.ts, which #1014 explicitly carved out as out of scope.Summary
Three deletions / changes in
src/server/static-react/src/constants/ui.ts:TAB_TRANSITION_DURATION_MS(was line 11) — deleted. Zero consumers acrosssrc/server/static-react/. The// Tab Configuration and Navigationbanner above it is kept because the siblingFORM_FIELD_DEBOUNCE_MS(still live) lives under the same banner.AUTH_INDICATORS+ its banner comment (was lines 132-137) — deleted. Zero consumers acrosssrc/server/static-react/. Banner only described this one const, so it goes too.MutationTypeOptioninterface (was line 107) — kept, butexportkeyword dropped. The interface is still referenced inside this file as the type parameter forMUTATION_TYPES; it has zero external consumers, so it's now file-internal.Verified by
git grepat base commit2fe8cea:TAB_TRANSITION_DURATION_MS→ 1 hit pre-edit (declaration), 0 post-editAUTH_INDICATORS→ 1 hit pre-edit (declaration), 0 post-editMutationTypeOption→ 2 hits both pre- and post-edit, both insideconstants/ui.ts(the interface decl + theMUTATION_TYPEStype annotation)export interface MutationTypeOption→ 0 hits post-editNet diff: 1 file, +1/-9.
Test plan
npm run typecheck— cleannpm run lint— no new warnings/errors in the touched file (the 1 pre-existing error inQueryForm.tsxis unrelated)npm test— 788 tests pass🤖 Generated with Claude Code