This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(sidebar): drop dead SIDEBAR_ITEMS re-export - #1018
Merged
Conversation
The named `export { SIDEBAR_ITEMS }` at the bottom of
src/server/static-react/src/components/Sidebar.tsx has no consumers —
the constant is only used internally by the Sidebar component itself
(declaration at line 26, .filter() use inside renderGroup). Continues
the audit pattern from #1014/#1015/#1016/#1017 which removed the
SidebarItem type and SIDEBAR_ITEMS from constants/ui.ts.
The local `interface SidebarItemDef`, `const SIDEBAR_ITEMS`, and the
`export default Sidebar` are untouched.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 12, 2026 08:14
4 tasks
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 12, 2026
SchemaCacheMeta and DefaultSchemaState are used only inside redux.ts (as the type of the `cache` field and the annotation on DEFAULT_SCHEMA_STATE, respectively); the constants barrel doesn't re-export them. Continues the dead-export audit pattern from PRs #1014, #1015, #1016, #1017, and #1018. Interfaces are preserved as file-local typing. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delete the dead
export { SIDEBAR_ITEMS }re-export at the bottom ofsrc/server/static-react/src/components/Sidebar.tsx. The named export haszero consumers anywhere in the codebase —
SIDEBAR_ITEMSis only usedinternally by the Sidebar component itself (declaration at line 26,
.filter()use insiderenderGroup).Continues the dead-export audit pattern from #1014, #1015, #1016, #1017
which removed
SidebarItemandSIDEBAR_ITEMSfromconstants/ui.ts.Those PRs explicitly listed this re-export as out-of-scope follow-up.
What stays
interface SidebarItemDef(line 17) — local-only, used by the componentconst SIDEBAR_ITEMS: SidebarItemDef[](line 26) — local-only, used at line 57export default Sidebar(line 122) — consumed byApp.tsx:8Verification
grep "SIDEBAR_ITEMS" src/server/static-react/src/returns exactly 2 hitsin
Sidebar.tsx(the local declaration and the in-component.filter()use)and 0 hits anywhere else.
npm run typecheck— cleannpm test— 788/788 passingTest plan
App.tsximport path unchanged)