This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(cloud-migration): unexport 3 internal poll-timing constants - #1027
Merged
shiba4life merged 1 commit intoMay 13, 2026
Merged
Conversation
ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ts-unused-exports tsconfig.jsonflagged three exports insrc/server/static-react/src/components/tabs/CloudMigrationSettings.tsx:UPGRADE_POLL_INTERVAL_MSUPGRADE_POLL_MAX_MSCANCELLED_BANNER_MSAll four call sites for these constants are inside the same file (lines 91, 120, 124, 127). The colocated test file
src/test/components/tabs/CloudMigrationSettings.test.tsxdoes not import them — it exercises the poll behavior end-to-end through the public component.Drop the
exportkeyword on the threeconstdeclarations. Behavior-preserving; pure dead-export sweep.Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
Test plan
npx ts-unused-exports tsconfig.jsonno longer listsCloudMigrationSettings.tsxnpm run typecheckcleannpm run lint— 0 errors (warning count unchanged)npm test— 788/788 passing, including the CloudMigrationSettings test file