This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(constants/ui): drop dead SidebarItem + SIDEBAR_ITEMS - #1017
Merged
Conversation
Both have zero importers. Sidebar.tsx defines its own local SidebarItemDef interface and SIDEBAR_ITEMS constant, never importing from constants/ui. Continues the dead-export audit from #1014, #1015, and #1016. - Delete `export interface SidebarItem` (was ui.ts:20-25) - Delete `export const SIDEBAR_ITEMS` (was ui.ts:62-72) plus its misleading comment claiming it was used by the Sidebar component Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
shiba4life
enabled auto-merge
May 12, 2026 07:18
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 12, 2026
SchemaCacheMeta and DefaultSchemaState are used only inside redux.ts (as the type of the `cache` field and the annotation on DEFAULT_SCHEMA_STATE, respectively); the constants barrel doesn't re-export them. Continues the dead-export audit pattern from PRs #1014, #1015, #1016, #1017, and #1018. Interfaces are preserved as file-local typing. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure deletion of two dead exports from
src/server/static-react/src/constants/ui.ts. Both have zero importers anywhere in the frontend tree —Sidebar.tsxdefines its own localSidebarItemDefinterface andSIDEBAR_ITEMSconstant and never imports fromconstants/ui.export interface SidebarItem(wasui.ts:20-25)export const SIDEBAR_ITEMS+ its misleading "used by Sidebar component" comment (wasui.ts:62-72)Continues the dead-export audit from #1014 (
constants/api.tsconsts), #1015 (constants/ui.tsother dead consts), and #1016 (SchemaStatetype aliases).Net diff: 1 file, 19 deletions, 0 insertions.
Test plan
git grep -nE "import .*\b(SIDEBAR_ITEMS|SidebarItem)\b" -- src/server/static-react/src→ 0 hits (confirmed pre- and post-edit)src/server/static-react/src/components/Sidebar.tsxuntouched; localSidebarItemDef(line 17) and localSIDEBAR_ITEMS(line 26) intactnpm run typecheck(tsc --noEmit) — passesnpm test(vitest) — 65 files / 788 tests pass;constants.test.tshas no assertions on the deleted exportsnpm run lint— the only error (schemasLoadingunused inQueryForm.tsx:45) pre-exists onorigin/mainand is unrelated to this diffOut of scope
export { SIDEBAR_ITEMS }re-export atcomponents/Sidebar.tsx:121(separate task; needs its own verification pass)Sidebar.tsx's localSidebarItemDefinto a shared module (re-architecture, not dead-code removal)