This repository was archived by the owner on May 13, 2026. It is now read-only.
refactor(api/views): drop 3 dead exports + unexport 2 internal types - #1022
Merged
Conversation
viewsClient.ts exported ViewState, getView, createView, and CreateViewRequest with zero references anywhere else in the codebase; TransformView and ViewListResponse were exported but only used file-locally (TransformView indirectly through ViewWithState). Removed the dead symbols and dropped the export keyword on the two file-local types. ViewWithState and the four active CRUD functions (listViews, approveView, blockView, deleteView) are untouched, and ViewsTab.tsx — the only external consumer — is unchanged. Same pattern as #1014/#1015/#1017/#1018.
shiba4life
enabled auto-merge
May 12, 2026 11:14
This was referenced May 12, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 13, 2026
…1027) ts-unused-exports flagged UPGRADE_POLL_INTERVAL_MS, UPGRADE_POLL_MAX_MS, and CANCELLED_BANNER_MS in CloudMigrationSettings.tsx. All four call sites are inside the same file; the colocated test file does not import them. Drop the `export` keyword on the three const declarations. Behavior-preserving — pure dead-export sweep. Continues the cleanup from #1014/#1015/#1017/#1018/#1022/#1023/#1024/#1025/#1026.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/server/static-react/src/api/clients/viewsClient.tsexported sixsymbols that ts-unused-exports flagged. Of those:
ViewState,getView,createView,CreateViewRequest— zeroreferences anywhere in the codebase → deleted.
TransformView,ViewListResponse— only used file-locally(
TransformViewindirectly through the still-exportedViewWithStatetuple,
ViewListResponseas the response type forlistViews)→ kept but unexported.
ViewWithStateand the four active CRUD functions (listViews,approveView,blockView,deleteView) are untouched. The onlyexternal consumer —
src/server/static-react/src/components/tabs/ViewsTab.tsx— imports exactly those five symbols and nothing else from this file,
so its imports are unaffected.
Net diff: 1 file changed, 2 insertions(+), 31 deletions(-).
Same pattern as #1014 / #1015 / #1017 / #1018.
Test plan
npm run typecheckpasses (no missed references)npm test(vitest) — 65 files / 788 tests passnpx ts-unused-exports tsconfig.json | grep viewsClient.tsreturnsnothing
🤖 Generated with Claude Code