Store storefront config in encrypted ejson files - #577
Merged
Conversation
This was referenced Aug 5, 2026
Contributor
Author
This was referenced Aug 5, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 5, 2026 11:06
d854029 to
5dfb0bb
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 5, 2026 11:06
d06a603 to
3cec2c3
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 5, 2026 11:35
5dfb0bb to
b16294b
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
2 times, most recently
from
August 5, 2026 11:45
af064ae to
386cb6e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 5, 2026 11:45
b16294b to
0075a38
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 5, 2026 12:33
386cb6e to
92ea555
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 5, 2026 12:33
0075a38 to
9571f14
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 6, 2026 15:48
92ea555 to
b9ad2ea
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 6, 2026 15:48
9571f14 to
398373e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 6, 2026 17:30
398373e to
ae576c3
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 6, 2026 17:30
b9ad2ea to
75a74ce
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 7, 2026 11:05
ae576c3 to
739c95b
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 7, 2026 11:05
75a74ce to
1eb65b9
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 7, 2026 11:25
739c95b to
028246e
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 7, 2026 11:26
1eb65b9 to
10e444c
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 7, 2026 13:51
028246e to
f3bba28
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 7, 2026 13:51
10e444c to
31f2d6e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 7, 2026 14:15
f3bba28 to
b874950
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 7, 2026 14:15
31f2d6e to
302bbf3
Compare
kieran-osgood-shopify
marked this pull request as ready for review
August 7, 2026 15:25
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 7, 2026 15:41
302bbf3 to
5c28904
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-customer-account
branch
from
August 10, 2026 09:08
b874950 to
9040a4d
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 10, 2026 09:08
5c28904 to
5161788
Compare
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-checkout-customer-account
to
graphite-base/577
August 10, 2026 14:01
kieran-osgood-shopify
force-pushed
the
graphite-base/577
branch
from
August 10, 2026 14:01
9040a4d to
a5f0a20
Compare
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 10, 2026 14:01
5161788 to
38ebbf3
Compare
Root `.env` currently serves both the sample apps and the E2E suite, so running the suite overwrites the storefront config a developer keeps for their own store, and none of those values can be shared or reviewed. This first step adds the encrypted source of truth and the tooling around it. Nothing reads these files yet, so behaviour is unchanged. - `config/secrets/demo.ejson` and `config/secrets/e2e.ejson` hold every value, secret and non-secret, so no plaintext config exists to commit by accident. Each holds one `environment` object, the only key `ejson2env` reads, plus a `_description` that ejson leaves unencrypted. - `scripts/ejson_lint` fails on any unencrypted value and reports key names only. It needs no private key, so it runs on forks. Wired into `dev check`. - `scripts/install_ejson_key` fetches the private key from GCP Secret Manager into the ejson keydir during `dev up`. The key travels through a redirect, so it never reaches argv, an environment variable, or the output. Every failure path exits 0: a developer without the key keeps full control of their own `.env`. - `scripts/secrets_edit` backs `dev secrets edit <demo|e2e>`. It decrypts to a private temporary copy, opens $EDITOR, restores the ciphertext of unchanged values so the diff shows only real changes, then writes back content that is already encrypted. No plaintext reaches the working tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
ejson
branch
from
August 11, 2026 16:50
38ebbf3 to
5008576
Compare
kyle-schellen
approved these changes
Aug 11, 2026
kyle-schellen
left a comment
kyle-schellen
left a comment
Contributor
There was a problem hiding this comment.
Tested locally and no issues 👍 🎉
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
Adds an encrypted ejson file for the e2e configuration and the demo app
Adds a
dev secrets editcommand that wraps updecryption -> editing -> encryptionflow so edits are secureThis is how the flow works in practice, a 1 time prompt to download the private key for decryption, and then dev up will work smoothly going fowards
Screen.Recording.2026-08-11.at.17.57.52.mov
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.