fix(e2e): dismiss only an enabled element on iOS - #574
Closed
kieran-osgood-shopify wants to merge 2 commits into
Closed
fix(e2e): dismiss only an enabled element on iOS#574kieran-osgood-shopify wants to merge 2 commits into
kieran-osgood-shopify wants to merge 2 commits into
Conversation
React Native — Coverage Report
|
Web — Coverage Report
|
kieran-osgood-shopify
marked this pull request as draft
August 5, 2026 09:35
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
FailuresCaution These E2E checks are not yet required, so they do not block merging — but a failure may still indicate a real issue to resolve before merging.
iOS — react-native
Android — react-native
iOS — swift
|
kieran-osgood-shopify
force-pushed
the
kieran-osgood/android-guest-cart-market
branch
from
August 5, 2026 09:53
4ac9954 to
6643cfb
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-dismiss-enabled-element
branch
from
August 5, 2026 10:38
15097ed to
b63d86b
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/android-guest-cart-market
branch
from
August 6, 2026 15:48
6643cfb to
6bff379
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-dismiss-enabled-element
branch
from
August 6, 2026 15:48
b63d86b to
33d5f72
Compare
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
The Android sample gave a guest cart a Canadian buyer identity. A country on the buyer identity picks the market, and the market decides the currency, the address form and its labels, so the Kotlin checkout rendered a Canadian form and totalled in CAD. The Swift and React Native samples send no buyer identity for a guest, so this one now sends none either. This is flake B4: the shared E2E fixture is a United States address, and checkout-guest failed on Kotlin Android while React Native Android passed the same test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/5b4b8d5b-690a-4389-841e-039723ade1da
The checkout page renders a disabled 24 by 22 pixel node whose accessibility text is "selected". The branch matched that node and tapped a fixed point after every text entry, so the next field never opened. Three tests failed across two targets. Guard the selector with a test. Add `e2e/flows/**` to the CI path filter, because no filter watched that directory and none of the flow guards ran. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/android-guest-cart-market
branch
from
August 6, 2026 17:30
6bff379 to
9ceb6c5
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-dismiss-enabled-element
branch
from
August 6, 2026 17:30
33d5f72 to
6f6a7d3
Compare
kieran-osgood-shopify
changed the base branch from
kieran-osgood/android-guest-cart-market
to
graphite-base/574
August 7, 2026 11:05
Contributor
Author
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are you making?
The iOS checkout page renders a disabled 24 by 22 pixel node whose accessibility text is exactly
selected. The bare selector indismiss-active-field.yamlmatched that node, so Maestro tapped the fixed point behind it after every text entry, and the field that followed never opened. Anchoring cannot fix this, because the text matches exactly. Requireenabled: trueon both thevisiblecondition and thetapOn.Add a guard in
maestro_test_tags_test.rbthat rejects a bareselectedselector.Widen the
scriptspath filter inci.ymlto watche2e/flows/**. That filter is the only thing that selects thescripts-testjob, and that job is the only thing that runs the Ruby guards. Several guards readflows/, so a commit that only edits a flow ran none of them.How to test
191 runs, 596 assertions, 0 failures.
🤖 Generated with Claude Code