Skip to content

feat(e2e): add the present-and-close checkout test on all four targets - #559

Merged
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/e2e-present-and-close-checkout
Aug 14, 2026
Merged

feat(e2e): add the present-and-close checkout test on all four targets#559
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/e2e-present-and-close-checkout

Conversation

@kieran-osgood-shopify

@kieran-osgood-shopify kieran-osgood-shopify commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What changes are you making?

Adds a present && close checkout test e2e/tests/shared/checkout-present-and-close.yaml
This exercises the cart builder path so we can remove e2e/tests/shared/checkout-present-and-close.yaml as duplicated code

We were also able to simplify some assertions that are now unified on the platforms

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)
Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

This was referenced Jul 31, 2026
Merged
Merged
Merged
Merged
@kieran-osgood-shopify Graphite App

kieran-osgood-shopify commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jul 31, 2026
Merged
Merged
@github-actions github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 31, 2026
This was referenced Jul 31, 2026
Merged
Merged
Closed
@tiagocandido
tiagocandido force-pushed the kieran-osgood/e2e-cart-from-control-link branch from 8a529fd to 893721f Compare August 3, 2026 12:12
@tiagocandido
tiagocandido force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 4783464 to 528c5d6 Compare August 3, 2026 12:12
@tiagocandido
tiagocandido force-pushed the kieran-osgood/e2e-cart-from-control-link branch from 893721f to ecc30cc Compare August 3, 2026 14:42
@tiagocandido
tiagocandido force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 528c5d6 to cd3c10f Compare August 3, 2026 14:42
This was referenced Aug 3, 2026
Merged
Merged
Merged
Closed
Closed
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-cart-from-control-link branch from ecc30cc to f3d5bf1 Compare August 4, 2026 17:04
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from cd3c10f to 10a2582 Compare August 4, 2026 17:04
This was referenced Aug 4, 2026
Merged
Merged
Merged
Closed
Open
Closed
Open
Closed
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/559 to kieran-osgood/e2e-cart-from-control-link August 12, 2026 12:28
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-cart-from-control-link branch from 069bad6 to 68a47a1 Compare August 12, 2026 12:33
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from ea67a5e to aaa98a8 Compare August 12, 2026 12:34
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-cart-from-control-link branch from 68a47a1 to a599103 Compare August 12, 2026 13:50
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from aaa98a8 to 6fb4a54 Compare August 12, 2026 13:50
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-cart-from-control-link to graphite-base/559 August 12, 2026 13:58
@kieran-osgood-shopify
kieran-osgood-shopify marked this pull request as ready for review August 12, 2026 14:53
@kieran-osgood-shopify
kieran-osgood-shopify requested a review from a team as a code owner August 12, 2026 14:53
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 6fb4a54 to 326c0ba Compare August 12, 2026 14:54
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/559 to kieran-osgood/e2e-cart-from-control-link August 12, 2026 14:54
@bitrise

bitrise Bot commented Aug 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK Install
React Native Install with Tophat
Swift Install with Tophat
Kotlin Install with Tophat

Checkout Kit E2E results

Status Suite Target Platform OS version tag Device
✅ react-native-ios react-native ios latest iPhone 15
iOS 27 Beta
✅ react-native-android react-native android latest Google Pixel 9
Android 17.0
✅ kotlin-android kotlin android latest Google Pixel 9
Android 17.0
✅ swift-ios swift ios latest iPhone 15
iOS 27 Beta

@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-cart-from-control-link to graphite-base/559 August 12, 2026 16:39
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 326c0ba to a868750 Compare August 13, 2026 11:50
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/559 to kieran-osgood/e2e-cart-from-control-link August 13, 2026 11:51
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-cart-from-control-link to graphite-base/559 August 13, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from a868750 to 4cea2b7 Compare August 13, 2026 13:41
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/559 to kieran-osgood/e2e-cart-from-control-link August 13, 2026 13:41
kyle-schellen
kyle-schellen reviewed Aug 13, 2026
View reviewed changes
Comment thread e2e/README.md
Comment thread e2e/README.md
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-cart-from-control-link to graphite-base/559 August 14, 2026 09:34
@kieran-osgood-shopify @claude
feat(e2e): add the present-and-close checkout test on all four targets
d80860a 
Second test of the rollout. It seeds a cart through the control link, presents
checkout, closes it, and asserts the sheet is gone. Swift iOS, Kotlin Android,
React Native iOS and React Native Android all run it.

Assert on the close control, not on checkout copy: the React Native catalog
sells a product called "Email", which the checkout field pattern matches, so
copy-based assertions pass on the wrong screen.

Extract flows/checkout/close.yaml so the close identifier, which differs by SDK
version rather than by platform, has one home. The React Native order flow now
calls it instead of carrying its own platform split.

The four targets return to different screens after the sheet closes, so this
test asserts dismissal only. The tests that place an order assert the cart.

Add the checkout tag to the CI matrix and exclude full, because the remaining
full tests place a real order and live under tests/react-native/.

Pass the installed device to Maestro from both native runners. Maestro
otherwise picks a device itself, and it can pick one the app is missing from.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@kieran-osgood-shopify
kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 4cea2b7 to d80860a Compare August 14, 2026 14:35
@kieran-osgood-shopify
kieran-osgood-shopify changed the base branch from graphite-base/559 to main August 14, 2026 14:35
@kieran-osgood-shopify
kieran-osgood-shopify merged commit 3a7abd9 into main Aug 14, 2026
40 of 47 checks passed
@kieran-osgood-shopify
kieran-osgood-shopify deleted the kieran-osgood/e2e-present-and-close-checkout branch August 14, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyle-schellen kyle-schellen kyle-schellen approved these changes

Assignees

No one assigned

Labels

#gsd:50662 Rebase Checkout Kit on UCP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kieran-osgood-shopify @kyle-schellen