Promote checkout-guest to run on Swift/Kotlin - #561
Merged
Conversation
This was referenced Jul 31, 2026
Contributor
Author
This was referenced Jul 31, 2026
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
added a commit
that referenced
this pull request
Jul 31, 2026
Six tests pass locally on all four targets and fail on BrowserStack. PR #561 and PR #562 show the same two patterns, so no sample change causes them. Both patterns need the Maestro logs, which need BrowserStack access. Separate them from the flake register, because a flake gives a different result from the same code and these give the same result every run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/5b4b8d5b-690a-4389-841e-039723ade1da
tiagocandido
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 3, 2026 12:12
4538a43 to
ec85833
Compare
tiagocandido
changed the base branch from
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
to
graphite-base/561
August 3, 2026 14:42
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-guest
branch
from
August 4, 2026 17:04
0b5e09e to
260aa4a
Compare
kieran-osgood-shopify
force-pushed
the
graphite-base/561
branch
from
August 4, 2026 17:04
ec85833 to
06ebb2e
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/561
to
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
August 4, 2026 17:04
kieran-osgood-shopify
marked this pull request as draft
August 5, 2026 09:20
This was referenced Aug 5, 2026
kieran-osgood-shopify
marked this pull request as ready for review
August 14, 2026 16:17
markmur
approved these changes
Aug 14, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 17, 2026 12:51
8fcbde6 to
a2b1a2f
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-guest
branch
from
August 17, 2026 12:51
df7a799 to
81de4d9
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
branch
from
August 17, 2026 13:13
a2b1a2f to
e7b6633
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-guest
branch
from
August 17, 2026 13:13
81de4d9 to
d7d962c
Compare
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
to
graphite-base/561
August 17, 2026 14:38
kieran-osgood-shopify
force-pushed
the
graphite-base/561
branch
from
August 18, 2026 09:27
e7b6633 to
7efb7a6
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-guest
branch
from
August 18, 2026 09:27
7238234 to
111f3ea
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/561
to
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
August 18, 2026 09:27
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-checkout-hardcoded-buyer-identity
to
graphite-base/561
August 18, 2026 10:24
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-checkout-guest
branch
from
August 18, 2026 10:24
111f3ea to
ee190fc
Compare
kieran-osgood-shopify
force-pushed
the
graphite-base/561
branch
from
August 18, 2026 10:24
7efb7a6 to
5f282b0
Compare
Moves the guest checkout test out of tests/react-native and into tests/shared, so Swift, Kotlin, React Native iOS and React Native Android all run it. The old file carried a wip tag to keep it out of the matrix; both go away together. Three flow fixes came out of running it: - fill-shipping-address.yaml asked for visibilityPercentage 10 in four places. A value under 100 rounds down to zero, so those scrolls stopped before they moved. centerElement replaces all four. - The shop requires a phone number on a delivery address, and no flow filled it. The field only appears when a shop asks for it, so the new step is optional. - Checkout copies the delivery name into "Name on card", and inputText appends to it. fill-payment-card.yaml now erases the field first. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/5b4b8d5b-690a-4389-841e-039723ade1da
Package Size
React Native file breakdown
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Similar to #560 - moves the checkout-guest flow to also run on Swift/Kotlin
This will now mean every e2e command should report 4/4 tests run (swift/kotlin/rnios/rnandroid)
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.