feat(e2e): add an E2EController to each sample app - #555
Merged
Conversation
11 tasks
Contributor
Author
This was referenced Jul 31, 2026
tiagocandido
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 3, 2026 12:12
fd87aa1 to
278ce30
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-controller
branch
2 times, most recently
from
August 3, 2026 14:42
c5d3696 to
fe4b7c7
Compare
tiagocandido
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 3, 2026 14:42
278ce30 to
66ee89d
Compare
This was referenced Aug 3, 2026
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 4, 2026 17:04
66ee89d to
7c28f96
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 4, 2026 17:04
fe4b7c7 to
5034ed1
Compare
This was referenced Aug 4, 2026
This was referenced Aug 6, 2026
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-control-link
to
graphite-base/555
August 6, 2026 17:06
kieran-osgood-shopify
force-pushed
the
graphite-base/555
branch
from
August 6, 2026 17:30
1bbb44a to
9a982e4
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 6, 2026 17:30
1d9643c to
7c8c6aa
Compare
kieran-osgood-shopify
changed the base branch from
graphite-base/555
to
kieran-osgood/e2e-control-link
August 6, 2026 17:30
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
from
August 7, 2026 11:05
9a982e4 to
e650dc3
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 7, 2026 11:05
7c8c6aa to
bb2d777
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
2 times, most recently
from
August 7, 2026 11:21
ae68cf6 to
a3846f6
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
2 times, most recently
from
August 7, 2026 13:51
be0b6ac to
5dc2272
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-control-link
branch
2 times, most recently
from
August 10, 2026 09:08
38169bc to
e746744
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 10, 2026 09:08
5dc2272 to
467121c
Compare
kieran-osgood-shopify
marked this pull request as ready for review
August 10, 2026 13:44
Package Size
React Native file breakdown
Android file breakdown
Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report. |
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kyle-schellen
approved these changes
Aug 11, 2026
kyle-schellen
left a comment
Contributor
There was a problem hiding this comment.
This seems good to me!
kieran-osgood-shopify
changed the base branch from
kieran-osgood/e2e-control-link
to
graphite-base/555
August 12, 2026 10:23
kieran-osgood-shopify
force-pushed
the
graphite-base/555
branch
from
August 12, 2026 10:23
e746744 to
c66804a
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 12, 2026 10:23
467121c to
6609003
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 12, 2026 10:23
6609003 to
d76cfa1
Compare
Every E2E command now enters one controller per sample. The controller composes existing primitives only, so E2E logic stays out of the cart, storefront and account code that merchants read as integration guidance. An injectable E2ECommandTarget makes the decision order testable without a network or a UI. Eight tests per platform assert an ordered list of calls, which pins the one rule that matters: selecting a buyer identity mode resets the cart, so it must run before seeding. Production code touches E2E in one named line per call site: SceneDelegate.scene(_:openURLContexts:), MainActivity, and Routes. Android needs two touch points, not one. Navigation state lives in Compose, so E2ENavigation plus one E2ENavigationEffect line lets the app self-navigate to the cart. The Maestro flow stops the app before opening the link, so a cold start delivers the intent to onCreate; both entry points route through E2EControlLinkHandler. The manifest gains a VIEW filter and singleTask. Swift gains a second URL scheme, without which openURLContexts never fires. Cart markers now match the React Native precedent on all four targets: the button carries checkout-button, the label carries cart-checkout-ready. signIn reports that it is not implemented yet. A later PR adds it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kieran-osgood-shopify
force-pushed
the
kieran-osgood/e2e-controller
branch
from
August 12, 2026 11:12
d76cfa1 to
7022342
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Previous PR added classes to handle parsing deep links for e2e scenarios
This one adds a controller for E2E that utilises the parser to receive the intent, and then dispatch the actions we need in the sample after
React Native already had most of the wiring as we set them up first so this PR brings kotlin and swift up to speed on wiring in the entry points for deep links into the E2EControlLink classes from PR #554
How to test
These things aren't wired up yet so nothing really to test, just dividing up the work
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.