Promote `cart-hardcoded-buyer-identity` test to run on swift/kotlin by kieran-osgood-shopify · Pull Request #560 · Shopify/checkout-kit

kieran-osgood-shopify · 2026-07-31T10:09:41Z

What changes are you making?

Previous Test suite state ran the guest/hardcoded buyer identity tests for react-native and excluded the "full" tag from swift/kotlin runs
This PR moves hardcoded buyer identity from tests/react-native to tests/shared, and modifies the tags so that we run them

How to test

Test suite should list hardcoded in the comment below for swift/kotlin

dev swift e2e and dev swift kotlin should now both report 3 tests (up from 2 on main)
CI should also report 3 tests for both of these

Before you merge

Important

I've added tests to support my implementation
I have read and agree with the Contribution Guidelines
I have read and agree with the Code of Conduct
I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?

I have bumped the version in ShopifyCheckoutKit.podspec
I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)

Releasing a new Embedded Checkout Protocol version?

I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed

Releasing a new Android version?

I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

kieran-osgood-shopify · 2026-07-31T10:09:56Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

kieran-osgood-shopify · 2026-08-13T13:08:45Z

  - full
+  # Only React Native runs this today, and every row now runs the whole tests folder.
+  # The shared guest test replaces this file, and this tag goes with it.
+  - wip


This gets removed in #561 when we promote guest to run on kotlin/swift

github-actions · 2026-08-14T14:43:05Z

Package Size

Platform	Artifact	Base	Head	Delta
Android	release AAR	279.8 KiB	279.8 KiB	0 B

Android file breakdown

File	Base	Head
`classes.jar`	295.6 KiB	295.6 KiB
`res/layout/checkout_view_content.xml`	2.6 KiB	2.6 KiB
`res/layout/checkout_sheet_content.xml`	2.0 KiB	2.0 KiB
`res/values/values.xml`	1.3 KiB	1.3 KiB
`R.txt`	1.2 KiB	1.2 KiB
`AndroidManifest.xml`	922 B	922 B
`proguard.txt`	798 B	798 B
`res/drawable/close.xml`	431 B	431 B
`res/menu/checkout_menu.xml`	354 B	354 B
`META-INF/com/android/build/gradle/aar-metadata.properties`	157 B	157 B

Measured from the PR base SHA and PR head SHA. The file breakdown shows uncompressed sizes within each package artifact, so individual files do not sum to the compressed artifact total. This comment reports package artifact sizes only; it is not a final app binary-size report.

bitrise · 2026-08-14T14:55:49Z

Install this build

Open Tophat, select your target device, then click Install. Links open on the Mac running Tophat.

SDK	Install
React Native	Install with Tophat
Swift	Install with Tophat
Kotlin	Install with Tophat

Checkout Kit E2E results

Status	Suite	Target	Platform	OS version tag	Device
✅	`react-native-ios`	react-native	ios	latest	iPhone 15 iOS 27 Beta
✅	`react-native-android`	react-native	android	latest	Google Pixel 9 Android 17.0
✅	`kotlin-android`	kotlin	android	latest	Google Pixel 9 Android 17.0
✅	`swift-ios`	swift	ios	latest	iPhone 15 iOS 27 Beta

markmur · 2026-08-14T16:23:40Z

                .padding(.bottom, 6)
            Text("Your cart is empty.")
                .font(.caption)
+                .accessibilityIdentifier(E2ETestIds.Cart.emptyMessage)


Would love if we could drop E2ETestIds in favour of something more generic like AccessibilityIdentifiers since this is sample code that a merchant might use

I can take care of this today if we want to merge these ones first.

kyle-schellen · 2026-08-14T16:57:32Z

                .padding(.bottom, 6)
            Text("Your cart is empty.")
                .font(.caption)
+                .accessibilityIdentifier(E2ETestIds.Cart.emptyMessage)


I can take care of this today if we want to merge these ones first.

### What changes are you making? Renames `E2ETestIds` to `AccessibilityIdentifiers` in the three sample apps, and moves it out of each sample's `e2e/` folder into a sibling `accessibility/` folder. Follow-up to [Mark's comment on #560](#560 (comment)): > Would love if we could drop `E2ETestIds` in favour of something more generic like `AccessibilityIdentifiers` since this is sample code that a merchant might use The samples are reference code merchants read to learn Checkout Kit. They don't need to know we drive these apps with an E2E suite, so our test vocabulary shouldn't show up in the screens they're reading. `AccessibilityIdentifiers` is also just the more accurate name — these are applied via `accessibilityIdentifier`, `testTag` and `testID`. The file moves out of `e2e/` for the same reason: leaving it there would keep `e2e` in the import line of every screen. **No behaviour change.** Every identifier value is byte-for-byte identical, so no Maestro flow, tag or matrix entry is affected. **Still in** **`e2e/`:** the harness itself (`E2EController`, `E2EControlLink`, `E2ESampleAppTarget`, `useE2ECartBootstrap`). That code really is test infrastructure, and the label is what tells a merchant to skip the folder. ### How to test CI covers all three platforms. --- ### Before you merge > [!IMPORTANT] > - [x] I've added tests to support my implementation — existing identifier tests carried over and renamed on all three platforms > - [x] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md) > - [x] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md) > - [ ] I've updated the relevant platform README — n/a, sample-internal rename with no public API change

…rgets Row 3 of the test rollout. The cart carries the contact details and the delivery address, so checkout asks only for payment. That makes this the shortest real order, and the first test to look at when checkout breaks. The test moves from tests/react-native/ to tests/shared/, so Swift iOS, Kotlin Android, React Native iOS and React Native Android all run it. The matrix drops the `full` exclude entry that kept the ordering tests off the native rows. Android supplied only email, phone and country in its cart, while Swift and React Native both supplied a delivery address. Checkout therefore showed an empty Delivery form on Android only. CartInput.delivery now carries a pre-selected one-time address there too, which matches Swift. The address fields come from the same .env values the other samples read. Two Maestro details drive the flow changes: - A `visibilityPercentage` below 100 normalizes to zero, so `scrollUntilVisible` stops without scrolling. `centerElement: true` replaces it. A tap that lands on the keyboard does nothing, and Maestro still reports it as completed. - Android `hideKeyboard` issues a Back press when no keyboard is up, which closes the checkout sheet. dismiss-active-field.yaml therefore only ever follows an inputText. Verified green on all four targets, plus dev check, the Ruby suite, the Swift package and sample targets, the Android library and sample tests, the React Native JS and iOS tests, web and protocol. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Assisted-By: devx/ff2aa6e8-6c55-4f90-9e4e-f716ad36255d

### What changes are you making? Similar to #560 - moves the checkout-guest flow to also run on Swift/Kotlin This will now mean every e2e command should report 4/4 tests run (swift/kotlin/rnios/rnandroid) --- ### Before you merge > [!IMPORTANT] > > - [ ] I've added tests to support my implementation > - [ ] I have read and agree with the [Contribution Guidelines](./CONTRIBUTING.md) > - [ ] I have read and agree with the [Code of Conduct](./CODE_OF_CONDUCT.md) > - [ ] I've updated the relevant platform README (`platforms/swift/README.md` and/or `platforms/android/README.md`) --- <details> <summary>Releasing a new Swift version?</summary> - [ ] I have bumped the version in `ShopifyCheckoutKit.podspec` - [ ] I have bumped the version in `platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift` - [ ] I have updated the SwiftPM/CocoaPods version snippets in `platforms/swift/README.md` (major version only) </details> <details> <summary>Releasing a new Embedded Checkout Protocol version?</summary> - [ ] I have bumped `embeddedCheckoutProtocolAndroid` in `platforms/android/gradle/libs.versions.toml` - [ ] I have updated `protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api` if the public API changed </details> <details> <summary>Releasing a new Android version?</summary> - [ ] I have bumped `checkoutKitAndroid` in `platforms/android/gradle/libs.versions.toml` - [ ] I have updated the Gradle/Maven version snippets in `platforms/android/README.md` </details> > [!TIP] > See the [Contributing documentation](./CONTRIBUTING.md) for the full release process per platform.

github-actions Bot added the #gsd:50662 Rebase Checkout Kit on UCP label Jul 31, 2026

This was referenced Jul 31, 2026

Promote checkout-guest to run on Swift/Kotlin #561

Merged

feat(e2e): add the customer account checkout test on all four targets #562

Closed

tiagocandido force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 4783464 to 528c5d6 Compare August 3, 2026 12:12

tiagocandido force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from 4538a43 to ec85833 Compare August 3, 2026 12:12

tiagocandido force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 528c5d6 to cd3c10f Compare August 3, 2026 14:42

tiagocandido force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from ec85833 to 200f651 Compare August 3, 2026 14:42

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from cd3c10f to 10a2582 Compare August 4, 2026 17:04

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from 200f651 to 06ebb2e Compare August 4, 2026 17:04

kieran-osgood-shopify changed the title ~~Promote `cart-hardcoded-buyeridentity order test on all four targets~~ Promote cart-hardcoded-buyer-identity test to run on swift/kotlin Aug 13, 2026

kieran-osgood-shopify commented Aug 13, 2026

View reviewed changes

kieran-osgood-shopify force-pushed the graphite-base/560 branch from 326c0ba to 4cea2b7 Compare August 13, 2026 16:21

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from 7de4e16 to 29adbfa Compare August 13, 2026 16:21

kieran-osgood-shopify changed the base branch from graphite-base/560 to kieran-osgood/e2e-present-and-close-checkout August 13, 2026 16:21

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-present-and-close-checkout branch from 4cea2b7 to d80860a Compare August 14, 2026 14:35

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from 29adbfa to 16ff6a4 Compare August 14, 2026 14:35

kieran-osgood-shopify marked this pull request as ready for review August 14, 2026 14:41

kieran-osgood-shopify requested a review from a team as a code owner August 14, 2026 14:41

kieran-osgood-shopify changed the base branch from kieran-osgood/e2e-present-and-close-checkout to graphite-base/560 August 14, 2026 15:08

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from 16ff6a4 to 6dea94c Compare August 14, 2026 15:08

kieran-osgood-shopify force-pushed the graphite-base/560 branch from d80860a to 3a7abd9 Compare August 14, 2026 15:08

graphite-app Bot changed the base branch from graphite-base/560 to main August 14, 2026 15:09

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from 6dea94c to 8fcbde6 Compare August 14, 2026 15:09

markmur approved these changes Aug 14, 2026

View reviewed changes

kyle-schellen approved these changes Aug 14, 2026

View reviewed changes

kyle-schellen mentioned this pull request Aug 14, 2026

[E2E] Rename E2ETestIds to AccessibilityIdentifiers #650

Merged

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch 4 times, most recently from 6b8a8d5 to ca96b75 Compare August 17, 2026 14:51

kieran-osgood-shopify force-pushed the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch from ca96b75 to 7efb7a6 Compare August 18, 2026 09:27

kieran-osgood-shopify merged commit 5f282b0 into main Aug 18, 2026
35 checks passed

kieran-osgood-shopify deleted the kieran-osgood/e2e-checkout-hardcoded-buyer-identity branch August 18, 2026 10:24

kieran-osgood-shopify mentioned this pull request Aug 18, 2026

fix(e2e): configure the billing postal label #673

Merged

Navigation Menu

Uh oh!

Promote `cart-hardcoded-buyer-identity` test to run on swift/kotlin - #560

Promote `cart-hardcoded-buyer-identity` test to run on swift/kotlin#560
kieran-osgood-shopify merged 1 commit into
mainfrom
kieran-osgood/e2e-checkout-hardcoded-buyer-identity

kieran-osgood-shopify commented Jul 31, 2026 •

edited

Loading

Uh oh!

kieran-osgood-shopify commented Jul 31, 2026 •

edited

Loading

Uh oh!

kieran-osgood-shopify Aug 13, 2026

Uh oh!

github-actions Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

bitrise Bot commented Aug 14, 2026 •

edited

Loading

Uh oh!

markmur Aug 14, 2026

Uh oh!

kyle-schellen Aug 14, 2026 •

edited

Loading

Uh oh!

kyle-schellen Aug 14, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

kieran-osgood-shopify commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes are you making?

How to test

Before you merge

Uh oh!

kieran-osgood-shopify commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kieran-osgood-shopify Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Package Size

Uh oh!

bitrise Bot commented Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Install this build

Checkout Kit E2E results

Uh oh!

markmur Aug 14, 2026

Choose a reason for hiding this comment

Uh oh!

kyle-schellen Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kyle-schellen Aug 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kieran-osgood-shopify commented Jul 31, 2026 •

edited

Loading

kieran-osgood-shopify commented Jul 31, 2026 •

edited

Loading

github-actions Bot commented Aug 14, 2026 •

edited

Loading

bitrise Bot commented Aug 14, 2026 •

edited

Loading

kyle-schellen Aug 14, 2026 •

edited

Loading

kyle-schellen Aug 14, 2026 •

edited

Loading