Adopt competitive program: PR1 LME-20 pin + PR2 write policy - #100
Merged
Conversation
Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Land subject-ordered claims, authoritative ops, LME product-recall harness, hop executor V2, truthful hybrid status, and Gate 0 / qualification docs from staging (dev@1f2f26f). Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Point intake SOP and assessment pack at the post-cutover state (hardening merged to dev/main), refresh claims discipline, and add a dedicated copy/paste self-review prompt for the external reviewer. Record post-cutover OpMem/marketing staging pins and LME abort honesty. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Record staging deploy 1f2f26f LoCoMo 1x30 at 15/30 with honest compare vs Gate 0 18/30 and harden-local 14/30; refresh handoff surfaces. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Complete full-pass pins on deploy 1f2f26f and refresh external-review handoff surfaces with honest Gate 0 vs post-cutover compares. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Archive ACCEPT-with-modifications verdict, add competitive archaeology SOP/gap matrix/borrow log, and point handoff surfaces at PR1-PR10. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Surface extraction failure_reason in publish-mode job waits, require jobs_completed==jobs_expected with jobs_failed==0, and strip invalid UTF-8 before persist (root cause of LME-20 abort SQLSTATE 22021). Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Defense-in-depth for LME SQLSTATE 22021: sanitize text fields in UpsertMemory, atoms/events/entity hub, and evidence writers so provider extract paths cannot insert invalid byte sequences even if an earlier normalize step is skipped. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Record fail-closed abort on item 17 async barrier timeout after 16/20 clean items; note prior UTF-8 abort subject 4388e9dd now completes. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Idempotent /ingest/async could return a duplicate job_id that inflated jobs_expected by 1 and fail-closed a full 20/20 /recall LME-20 run. Deduplicate pending IDs in the harness; pin the attempt-2 failure artifact (UTF-8 and timeout gates cleared; proveability blocked). Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Attempt-2 scored 20/20 /recall but exited before json/manifest/report were written. Pin evidence first, then SystemExit on gaps. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Proveability passed: 20/20 /recall, jobs 4829=4829 failed=0. Accuracy 0/20 is honest integrity, not a quality win. Do not commit run manifests (env URLs trip secret scan). Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Core/empty vertical keeps provider NONE/UPDATE/DELETE from dropping or mutating prior conversational records. Non-core verticals retain #94 authoritative ops. No LoCoMo/LME quality claim. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
crm source_type skips deterministic episode extract, so seed ingest created zero memories. Vertical=support still selects governed mode. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
Rebuilt local API from this branch; no LoCoMo/LME quality claim. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
sdntsng
marked this pull request as ready for review
August 13, 2026 11:19
This was referenced Aug 13, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts the competitive architecture review as the program of record (ACCEPT with modifications), then executes PR1 (LME-20 measurement integrity) and PR2 (conversational vs governed write policy).
Strategic frame: recall broadly → represent explicitly → prove narrowly → answer truthfully.
Merge target is
devonly. Do not merge or push tomain/ production unless the owner explicitly asks.Honest pins only. No SOTA / beats-Mem0 claims. LME-20 0/20 is an integrity pin, not a quality win. LoCoMo remains post-cutover 15/30 and 33/90.
Changes
Phase 0 — program adoption (docs)
PR1 — LME measurement integrity (done)
failure_reason+ job accounting; proveability fail-closedjob_ids (attempt-2 off-by-one4829 != 4830)SystemExitlme20-product-recall-pr1-20260812:--publish --product-recall --limit 20 --seed 1 --async-timeout 3600answer_path=/recall20/20;jobs_expected=jobs_completed=4829;jobs_failed=0d6f21ea9d60a0d56f34a05b609c79c88a451d2ae03597821ea3d5a9678c3a442docs/benchmarks/artifacts/lme20-product-recall-pr1-20260812-pin.mdPR2 — conversational append-only vs governed mutation (code landed)
WriteMutationModeOf: core/empty vertical → append-only; any non-core vertical → governed (fix: provider NONE/DELETE/UPDATE authoritative over baseline #94 ops kept)/correct,/suppress,/supersedeAPIs unchangedTest plan
go test ./internal/memory/ ./internal/jobs/ ./internal/api/Linear / tracking
Competitive program of record:
docs/research/external-reviews/2026-08-11-competitive-architecture-verdict.mdStatus:
docs/research/program-execution-status.mdRisk / follow-ups
temporal_score, reuse mig-16), then PR4–PR10devfor PR3+mainwithout an explicit owner ask