fix: ContextEvidence vs ProofChain — stop hop packet replacement - #102
Merged
Conversation
bindPacketFromHopResults no longer replaces packet Contents/Items. ContextEvidence stays the broad search hits; hops become ProofChain for hop_join_proven. Hybrid reader leads with context. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
This was referenced Aug 13, 2026
4 tasks
sdntsng
marked this pull request as ready for review
August 13, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave D showed LME-20 0/20 with mean 24.45 search hits: hops and hybrid reading starve the reader of broad search context.
bindPacketFromHopResultscurrently replacespkt.Items/Contents/MemoryIDs, so the hybrid reader only sees hop-narrowed text.This is PR5 (context vs proof). Coverage /
hop_join_provenstill uses the hop proof chain. Reader/context assembly keeps SearchOpt hits.Changes
EvidencePacketgainsContextEvidenceandProofChain.bindPacketFromHopResultssnapshots search contents as context, appends hop items as proof, and does not wipe existing contents.formatHybridMemoryLinesleads with context, then the hop chain.Test plan
go test ./internal/memory/Linear / tracking
Wave D decision gate after #100: PR5 first.
Risk / follow-ups
IncludeHistorical+temporal_score) and PR4 (fixed-token budgets / episode penalty) are separate branches.devonly; do not merge tomain.