feat: MaxEvidenceTokens and fixed-budget candidate pools - #104
Merged
Conversation
Explicit candidate_limit qualifies 30/50/100/200 without inflating default top-k. Keep CandidateOverfetch cap at 200. Downrank untyped episodes so assistant boilerplate does not outrank typed facts. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave D: LME subjects have ~240 extracts and untyped
conversation_episoderows currently get +0.1episode_boost, which promotes assistant congratulations/listicles over typed facts (gold “4 weeks” vs rank-1 “3 weeks”).MaxEvidenceTokenson/recallwas dead.This is PR4 (retrieval V4 at fixed context tokens). Kill-list compliant: no unbounded top-k; default overfetch cap stays 200.
Changes
MaxEvidenceTokensas the evidence assembly budget when set (elseBudgetTokens/ 4000).SearchOptions.CandidateLimit+RecallRequest.CandidateLimit;CandidatePoolSizequalifies 30/50/100/200 and caps at 200.Test plan
go test ./internal/memory/Linear / tracking
Wave D after #100. Independent of PR5 (#102) and PR3 (#103) on
dev.Risk / follow-ups
date_token_boost/ exact span (existing tests).devonly; do not merge tomain.