feat: temporal_score + IncludeHistorical on temporal intent - #103
Merged
Conversation
Classify intents before SearchOpt so before/when/used-to queries include superseded state. Add temporal_score as a fusion channel (not recency +0.05). Tag memory_type in metadata; set event ends_at on supersede (mig-16 columns). Current-state still prefers Austin. Co-authored-by: Siddhant Singh <sdntsng@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave D: LME temporal-reasoning 0/6 and knowledge-update 0/3.
/recallsearched before intent classification, soIncludeHistoricalwas only set when the client sent it. Auto-supersede still hides prior state (NY) from default search after “moved to Austin”.This is PR3 (temporal retrieval V1). Reuses mig-16 columns (
valid_toalready written on atom retire;ends_atnow written on event close). No new event schema.Changes
IncludeHistoricalfor historical/temporal intents (before/when/ago/how long/used to).SearchOptalso upgrades from query intent so/memories/searchmatches/recall.temporal_scorefusion channel viaScoreAndRankV2Temporal(zero temporal does not changemax_possible).memory_type(state/event/episode) in record metadata — not a duplicate time table.EventEnder.EndMemoryEventsByMemoryIDsetsmemory_events.ends_aton supersede.Test plan
go test ./internal/memory/go test ./internal/store/postgres/ ./internal/jobs/ ./internal/api/(postgres/jobs/api were green with this change)Linear / tracking
Wave D gate after #100 / #101. Independent of PR5 (#102) on
dev.Risk / follow-ups
devonly; do not merge tomain.