Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23375
Note: Links to docs will display an error until the docs builds have been completed. ❌ 10 New Failures, 3 Unclassified FailuresAs of commit 59464d8 with merge base c16dd0a ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 2, 2026
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The off-graph KV cache now reaches Muse Glimmer through the batching path
only (export_solo_batching.py + run_solo_batching). This removes the earlier
single-sequence wiring from everywhere else in MG and switches the OSS CI mode
to the batching path, which now also tests batching itself.
Removed, so these match their state before the off-graph stack:
muse_glimmer_worker.cpp: the off-graph plan, cache building and install,
reset handling,
offgraph_initial_capacity, and the engine's part of CUDAgraph capture with the off-graph cache;
--use-offgraph-kv-cacheand its branches. Onepiece stays:
_solo_constant_methodsomitsget_mutable_buffer_metadatawhen there is none, because export_solo_batching.py shares it for a model
whose cache lives off-graph.
Kept as they are, because the batching path uses them: the off-graph source
transformation in source_transformations/cuda.py (with its tests in
test_cuda_pipeline.py), export_solo_batching.py and run_solo_batching.
The CUDA backend side of the stack (lowering, CudaKVPool, CudaSequenceKVCache,
CudaCellCache, delegate-driven steps, graph recapture) is unchanged; the
batching path uses it.
CI:
solo-text-offgraphbecomessolo-text-batching. It exports withexport_solo_batching.py and runs run_solo_batching three times:
solo-text-offgraph checked, "Paris");
longer than a forward (Germany), which prefills in slices beside the others'
decodes.
Each run writes a report, and .ci/scripts/check_muse_glimmer_batching_report.py
checks three things:
Rome, Paris, Berlin), and eager and graph decode generate the same tokens.
Tokens are not compared across batches: the France prompt prefilled alone
and the one prefilled beside others run GEMMs of different shapes, and on
the real model bf16 rounding steers greedy decoding differently (both
still answer Paris);
not vary by more than 256 MiB across runs reserving 4 or 5 sessions;
grows geometrically (at most twice what was needed) instead of reserving
every session's context, its bytes equal rows x bytes per cell, and
generation adds no more than the pool plus a 3 GiB activation slack.
The export's mode check now accepts this mode (it listed only solo-text and
dflash-image, so the old mode could not have passed it).
Differential Revision: D123051488