[executorch][llm] Share the batching executors' session logic under extension/llm/batching/util - #23371
Open
Gasoonjia wants to merge 1 commit into
Open
[executorch][llm] Share the batching executors' session logic under extension/llm/batching/util#23371Gasoonjia wants to merge 1 commit into
Gasoonjia wants to merge 1 commit into
Conversation
Gasoonjia
requested review from
kirklandsign,
larryliu0820 and
mergennachin
as code owners
October 2, 2026 19:07
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23371
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Pending, 3 Unclassified FailuresAs of commit f2c231d with merge base c16dd0a ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 2, 2026
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
ModuleExecutor and CudaExecutor (previous diff) carried copies of the same
logic. It moves into
util::SessionTable, which both now use:max_sessions, with session ids never reused;
pack(BatchInput): flattens a batch onto one token axis with a per-sequencecursor, so consecutive chunks of a prompt abut, and truncates reopened
sequences only after every input has checked out;
from its logits row.
Plus
util::select_rows, the logits rows a forward over one slice of a packedbatch selects.
What stays in each executor is what differs: how the program is read and
validated, and how slices map onto methods (one
forwardfor ModuleExecutor;decode/prefill for CudaExecutor).
No behavior change. Log messages from the moved code now say
pack:ratherthan
build_step:.Builds as
extension_llm_batching_util(CMake) and//executorch/extension/llm/batching:session_table(Buck).Differential Revision: D123051482