Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23369
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Unclassified FailuresAs of commit 80bfc20 with merge base c16dd0a ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 2, 2026
This was referenced Oct 2, 2026
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Step slicing for the CUDA batching executor, in backends/cuda/batching:
plan_slices (step_plan.h, header-only) cuts a batch of packed tokens into
forwards the exported decode/prefill methods can run, in order, so a slice
attends every cell its predecessors wrote.
Slices take up to
max_step_tokenseach. A one-token slice runs Decode (thestatic, one-token method a CUDA graph is captured for). A slice shorter than
min_prefill_tokens-- the lower bound the prefill method was exportedwith -- runs as that many Decode forwards; anything else runs Prefill (dynamic
over [min_prefill_tokens, max_step_tokens]).
Builds with Buck (
step_plan+test_step_plan) and CMake (header-onlyinstall,
test_step_planunder BUILD_TESTING; the batching dir is added fromthe OSS root after extension/llm/batching). The OSS unittest-cuda-runtime job
builds and runs
test_step_plan. The CudaExecutor itself, which consumes thisheader, follows in the child diff.
Differential Revision: D123066805