Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23367
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 5 Unclassified FailuresAs of commit 7db538f with merge base c16dd0a ( NEW FAILURE - The following job has failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 2, 2026
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The runtime half of the cell layout:
CudaCellCacheiscache::CellCache + CudaKVCache, the CUDA counterpart of MLXCellCache, builtover the CudaKVPool from the previous diff.
BatchControl verbs (seq_new/clone/rm, rewind, declare_step).
keeps its history there), plus the step buffers the cell lowering declares:
cells,read_len, and onemask_w{window}per distinct window.prepare_step(width, stream)places the declared tokens and writes theplacement, extent and per-window masks into those buffers on the step's
stream. Positions follow from the declaration (every token continues its
sequence), so nothing is read back from the device. The pool grows before
placement, to the furthest placement could reach, so a failed allocation
leaves the table untouched.
sequences. Only pool growth recaptures.
program bounds its sweep by read_len (guarded by a test in the lowering
diff).
Registered for
batched-celland forbatched, as the batch layout thisbackend serves.
The mutex is recursive because the base's verbs call each other virtually
(seq_clone takes its id through seq_new).
Differential Revision: D123051479