Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23373
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 2 Unclassified FailuresAs of commit d91f120 with merge base c16dd0a ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 2, 2026
This PR needs a
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Exports Muse Glimmer text generation as the artifact CudaExecutor drives. It
lives beside the single-sequence export_solo.py, which it leaves untouched.
Two methods over one set of weights, both
(tokens[1, T], input_pos[T], logits_to_keep[K]) -> logits[K, vocab]float32:decode: T = K = 1, static; the runtime captures it into a CUDA graph.prefill: T and K in [5, W], dynamic. MG's quantized linears switch kernelsat M <= 4, so a dynamic width only traces from 5, as in export_solo;
get_min_prefill_chunk = 5tells CudaExecutor to run narrower slices asdecodes.
The whole step runs through the decoder so every token's K/V reaches the
cache; only the rows the batch samples pass through the LM head.
The delegate reads the step's token count from
input_pos[T], the cacheops' position, as the backend's CheckOffGraphKVStepWidthPass requires. The
spec names a delegate input, and the delegate's inputs need not follow the
method's order: decode's delegate takes
(tokens, input_pos, logits_to_keep)(spec1:0), while prefill reads logits_to_keep'ssymbolic size first and takes
(tokens, logits_to_keep, input_pos)(spec2:0). Sampling happens on the host, per session, so logits are not kept onthe device.
Reuses export_solo's loaders and constant methods and the off-graph source
transform, whose manifest gains
layout: cellandmax_cells. Adds themetadata CudaExecutor reads:
get_max_context_len,get_logits_to_keep_mode = selected,get_offgraph_kv_max_cells, and thecache geometry.
CLI:
--gguf | --prequantized | --checkpoint-dir,--max-seq-len(theper-session context),
--max-step-tokens(W, default 512),--max-cells(the shared pool, default 65536; memory grows with use).
The new test also joins the OSS unittest-cuda job, where MG's CUDA tests did
not run before.
Differential Revision: D123051484