Repository navigation
Conversation
… Wizard's Sanctum drops - joins.json pairs may carry "kind": "step" (a straight walk both ways, at most 12 yd, no steeper than the walk slope, where neither map walks across) or "drop" (a one-way fall from a ledge's edge to where players land, kept even where it hurts and his maps make another way). - Orgrimmar: the drop off the wind rider tower's south edge into the Valley of Strength (29 yd; 121 recorded players take it). Stormwind: the 15 yd drop below High Sorcerer Andromath's floor in the Wizard's Sanctum (40 of 41 recorded players). - Test: the walk from Doras to Kaja goes off the tower's edge and is under 160 yd (the ramp's walk is 195). - Walking maps repacked in the next commit.
- forge nav pack --leffe (grid 1.60.1.70532, date 2026-11-16): one part changes, Polestar_Nav_Kalimdor/Nav1_30.lua, the tower's cluster (one arc). - The Wizard's Sanctum drop is taken out again: the walking maps already make that fall (the pack logged "his maps make it already"), so it added nothing.
…mwind and Orgrimmar - 29 joins from the players' recordings: places where recorded players (5 to 65 distinct ones each) walk across a gap neither our grid nor the walking maps join (a threshold, a counter's gap, a platform's steps), found where their walks jump across our grid and checked against the shipped maps; both sides on floors 3+ players walk. 27 are a few yards long and drawn straight (kind step); two are routed on our grid (one too long for a step, one too steep). - Ironforge: Daryl Riknussun's platform (the cooking trainer, #2860) is joined to the Great Forge's floor; it was walked to nowhere at his height. - 12 of the 29 add nothing to the shipped maps (they already make the way); they stay so a later pack whose maps lack it gets it. - Walking maps repacked (forge nav pack --leffe, grid 1.60.1.70532, date 2026-11-16): 16 Eastern Kingdoms parts change, Kalimdor none. - Tests: the walk to Daryl Riknussun at his height from the reporter's spot (found, ends on his platform, under 450 yd) and back from the forge; two of the busiest steps walked both ways at under 1.5x the straight line plus 20 yd.
…rted goal and Afadra Dunwall's spot - A strict join's way gets an arc (or an edge across a cluster border) wherever the walking maps lack a move of their own, even where they walk round to it within 40 yd: that way round can start a long detour. Step joins are always strict; joins.json pairs may say "strict": true. - Walking maps repacked: three Eastern Kingdoms parts change. - #2860's test walks to the report's goal point (60.25, 36.79) at Daryl Riknussun's height, which the unchanged maps can't reach (his spawn's point they reach by a 356 yd walk). - The second test now walks from Afadra Dunwall's spot (Ironforge 33.92, 49.31), cut off in the unchanged maps, to Thurgrum Deepforge and back.
This was referenced Nov 18, 2026
|
Other pull requests for the same issue
Please compare with them before going further. If one already covers the issue, close this one or offer the part it is missing there. One of them is merged, crediting whoever helped (CONTRIBUTING.md, "Before you start"). |
fitzforge
marked this pull request as ready for review
November 18, 2026 03:30
7 tasks done
…e city The step at 40.83, 49.01 (z 51, 5 recorded players) joined the ground the city was built over, which lies under its streets and is joined to the world only far away, to the canal side: a walk from that buried ground found a 620 yd way out instead of none (nav_maps' walk from ground joined only far away). The other Stormwind steps stay; maps repacked (Polestar_Nav_EK parts 11 and 12).
fitzforge
enabled auto-merge
November 18, 2026 05:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Builds on #2907 (the step and drop kinds); merge that first.
What and why
Places in the capitals where recorded players walk across and the walking maps had no way, or only a long way round: a door's threshold, a counter's gap, a platform's steps. Found from the players' own recordings: where a recorded walk jumps across a gap in our grid (two breadcrumbs on one level the grid can't join), the spot is clustered over players, the closest pair of floors across it is the step, and the shipped engine is asked whether it walks across. Kept only with 5+ distinct players stepping through (training players only: the gate's held-out players never chose a fix) and both sides on floors 3+ players walk. A second source, a navigation mesh's connectivity, proposed more spots; each was held to the same recordings evidence.
nav_maps' walk from ground joined only far away).joins.jsonpairs may also be marked"strict": true.Gate (held-out recorded walks in the capitals)
Same judge and baseline as #2907 (the shipped maps repacked unchanged). This pull request includes #2907's drop.
Baseline: the shipped maps repacked unchanged, city gate at the same commit (GAME = baseline-5's numbers in every city). After = this pull request, which includes #2907's drop; the step joins' own share is Ironforge's.
No walk newly fails in any city. Fixed in Ironforge: three walks onto Daryl Riknussun's platform, in both arms. The Stormwind steps change no held-out walk (their spots are walked rarely by the held-out players); they are kept on the recordings' evidence.
Checks
cargo test -p forge-nav --lib pack::(a strict way gets its arc where the maps only walk round)nav-reportedtests: the walk to Daryl Riknussun at his height from the reporter's spot is found, ends on his platform and is under 450 yd (before: no walk), and back; two of the busiest steps walked both ways at under 1.5x the straight line plus 20 ydforge nav check;nav_maps,nav_memoryandnav-reportedpass on the repacked maps;forge data subzonesrerun, nothing changes