Skip to content

Walking maps: the reach rule in the capitals (--ground cities, the default) - #2919

Draft
fitzforge wants to merge 16 commits into
feature/city-pathsfrom
city/ground-cities
Draft

fitzforge wants to merge 16 commits into
feature/city-pathsfrom
city/ground-cities

Conversation

@fitzforge

Copy link
Copy Markdown
Owner

Issues

  • I checked for open pull requests on the same subject and found none.

Builds on #2916 (and #2907); merge those first.

What and why

In the capitals a walk's end with a height settles on the surface nearest it. Where the walking maps keep floors no walk ever reaches (a counter's top, a sealed room, a roof, the ground under Stormwind's and Orgrimmar's streets), that surface can be one of them, and the walk comes back with no way, or the walk asked again without the goal's height goes round the city. The reach rule (Shortest Path Forever's, ported earlier and kept off) leaves that ground out, but measured world-wide it lost walks outside the cities where a goal stands on a ledge it drops.

  • forge nav pack --ground cities runs the reach rule and keeps every surface outside the capitals' zones: inside the cities unreachable ground goes, outside nothing changes. It is the default now (--ground all keeps all ground, --ground reached drops it everywhere).
  • Walking maps repacked with it.
  • The Undercity subzone test (Bug: walking route out of the Undercity Apothecarium points into a wall instead of up to the flight master #2244) expected two named floors at the Apothecarium; the maps keep its floor alone now (the floors over it were ground no player stands on). Its check that each language names the same floors as English still runs there and on the canal.

Gate (held-out recorded walks in the capitals)

(pending: maps being repacked without the Undercity)

Checks

  • cargo test -p forge-nav --lib pack:: (new: the surfaces outside the capitals are kept whatever the walks reach) and --test pack
  • nav-reported tests on the repacked maps
  • forge nav check, forge data subzones rerun
  • Outside the capitals: (pending)
  • A changelog fragment in changes/
  • An AI agent wrote or helped with this — Model and tool: Claude Opus (Anthropic), omp

…mwind and Orgrimmar

- 29 joins from the players' recordings: places where recorded players (5 to 65 distinct ones each) walk across a gap neither our grid nor the walking maps join (a threshold, a counter's gap, a platform's steps), found where their walks jump across our grid and checked against the shipped maps; both sides on floors 3+ players walk. 27 are a few yards long and drawn straight (kind step); two are routed on our grid (one too long for a step, one too steep).
- Ironforge: Daryl Riknussun's platform (the cooking trainer, #2860) is joined to the Great Forge's floor; it was walked to nowhere at his height.
- 12 of the 29 add nothing to the shipped maps (they already make the way); they stay so a later pack whose maps lack it gets it.
- Walking maps repacked (forge nav pack --leffe, grid 1.60.1.70532, date 2026-11-16): 16 Eastern Kingdoms parts change, Kalimdor none.
- Tests: the walk to Daryl Riknussun at his height from the reporter's spot (found, ends on his platform, under 450 yd) and back from the forge; two of the busiest steps walked both ways at under 1.5x the straight line plus 20 yd.
…rted goal and Afadra Dunwall's spot

- A strict join's way gets an arc (or an edge across a cluster border) wherever the walking maps lack a move of their own, even where they walk round to it within 40 yd: that way round can start a long detour. Step joins are always strict; joins.json pairs may say "strict": true.
- Walking maps repacked: three Eastern Kingdoms parts change.
- #2860's test walks to the report's goal point (60.25, 36.79) at Daryl Riknussun's height, which the unchanged maps can't reach (his spawn's point they reach by a 356 yd walk).
- The second test now walks from Afadra Dunwall's spot (Ironforge 33.92, 49.31), cut off in the unchanged maps, to Thurgrum Deepforge and back.
… capitals only

- forge nav pack --ground cities: the reach rule (ground no walk from a fixed place reaches is left out) runs as with --ground reached, but every surface whose cell lies outside the capitals' zones counts as reached, so the maps outside the cities stay whole.
- In the capitals a walk's end with a height then settles on ground a player reaches: not a counter's top, a sealed room or the ground under the streets.
- Test: keep_outside marks a cluster's surfaces outside the capitals reached and leaves the capital's.
- forge nav pack with --leffe drops the ground no walk reaches in the capitals unless told otherwise (--ground all keeps all of it, --ground reached drops it everywhere), so a repack keeps it.
- docs: the rule's measured effect on the city gate and why it stays off outside the cities.
- forge nav pack --leffe (now --ground cities by default; grid 1.60.1.70532, date 2026-11-16): in the capitals the ground no walk from a fixed place reaches is left out (Eastern Kingdoms 82,301 floors, Kalimdor 82,492); outside them nothing is dropped. Part files shift (one part fewer per continent) because the capitals' clusters are smaller.
- The reach walk doesn't ride the Undercity's lifts (they are lift chokepoints, not his graph), so it missed floors players reach there: on the broad sample 4 walks through the Undercity and the Ruins of Lordaeron were lost and 2 got longer. Its map frame (uiMap 1458) is left out of the rule.
- A changelog fragment for the capitals' reachable ground.
- Walking maps to be repacked in the next commit.
…e city

The step at 40.83, 49.01 (z 51, 5 recorded players) joined the ground the city was
built over, which lies under its streets and is joined to the world only far away,
to the canal side: a walk from that buried ground found a 620 yd way out instead of
none (nav_maps' walk from ground joined only far away). The other Stormwind steps stay;
maps repacked (Polestar_Nav_EK parts 11 and 12).
…left out

With --ground cities the capitals keep only the ground a walk from a fixed place reaches. Some
of what it drops is ground players walk: a floor his maps join to nothing, one step up from a
street (by Tymor in Ironforge's Mystic Ward, the cheese shop's floor in Stormwind's Trade
District). Eighteen steps join them where 5 or more recorded players step from ground that stays
onto it (Ironforge 13, Stormwind 2, Orgrimmar 3), so the rule keeps those floors and walks reach them.
# Conflicts:
#	addon/Polestar_Nav/PACK.json
#	addon/Polestar_Nav_EK/Nav0_11.lua
#	addon/Polestar_Nav_EK/Nav0_12.lua
…itals' step joins

The walk out of the Commons without a height expands everything its start reaches in the city's
cluster; the step joins add 4 floors and 41 arcs there, 49,231 -> 50,218 expansions for the same
153 yd path (no new ground outside the city: the walks onto the mountain over it are unchanged).
Limit 50,000 -> 51,000.
…city kept whole, and the new steps

Packed with --ground cities (the default) on the capitals' step joins of #2916 and the steps onto
walked floors. Polestar_Nav_EK has its part 41 again (the Undercity's ground is back). Subzones
rerun (forge data subzones): the floors named in the capitals follow the floors kept.
The street's floor at 102 in that cell is ground no walk reaches and no recorded player walks; the
reach rule in the capitals leaves it out. The walks to Westfall and back still go through the city
(3,467 and 3,464 yd).

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant