Repository navigation
Conversation
…mwind and Orgrimmar - 29 joins from the players' recordings: places where recorded players (5 to 65 distinct ones each) walk across a gap neither our grid nor the walking maps join (a threshold, a counter's gap, a platform's steps), found where their walks jump across our grid and checked against the shipped maps; both sides on floors 3+ players walk. 27 are a few yards long and drawn straight (kind step); two are routed on our grid (one too long for a step, one too steep). - Ironforge: Daryl Riknussun's platform (the cooking trainer, #2860) is joined to the Great Forge's floor; it was walked to nowhere at his height. - 12 of the 29 add nothing to the shipped maps (they already make the way); they stay so a later pack whose maps lack it gets it. - Walking maps repacked (forge nav pack --leffe, grid 1.60.1.70532, date 2026-11-16): 16 Eastern Kingdoms parts change, Kalimdor none. - Tests: the walk to Daryl Riknussun at his height from the reporter's spot (found, ends on his platform, under 450 yd) and back from the forge; two of the busiest steps walked both ways at under 1.5x the straight line plus 20 yd.
…rted goal and Afadra Dunwall's spot - A strict join's way gets an arc (or an edge across a cluster border) wherever the walking maps lack a move of their own, even where they walk round to it within 40 yd: that way round can start a long detour. Step joins are always strict; joins.json pairs may say "strict": true. - Walking maps repacked: three Eastern Kingdoms parts change. - #2860's test walks to the report's goal point (60.25, 36.79) at Daryl Riknussun's height, which the unchanged maps can't reach (his spawn's point they reach by a 356 yd walk). - The second test now walks from Afadra Dunwall's spot (Ironforge 33.92, 49.31), cut off in the unchanged maps, to Thurgrum Deepforge and back.
…nd Darnassus - 23 joins from the players' recordings where held-back players' walks failed on the walking maps (no walk, or 1.3x and 40+ yd round) and our grid walks the gap: the Undercity's Rogues' Quarter canal bridge (cut at its crest in the walking maps), the lifts' corridor steps, the Magic Quarter's bridges, the Trade Quarter's upper floor, the Apothecarium's door; Thunder Bluff's Spirit Rise bridge and the Winterhoofs' tent; Darnassus's Cenarion Enclave ramp, Eladriel's and Yldan's floors and two sets of steps. Most are strict: the walking maps' way round within 40 yd was the long one the walk took. - Thunder Bluff's wind rider tower: drop joins for the hops and drops players take off its south and north ledges (52 of 53 and 49 of 61 players passing the ledges; 142 of 196 players leaving Tal show the falling flag). - Walking maps repacked (forge nav pack --leffe, grid 1.60.1.70532, date 2026-11-16): 7 Eastern Kingdoms and 3 Kalimdor parts change. - Tests: the walk across the Undercity bridge to Mennet Carkad, Tal to Innkeeper Pala off the tower's ledges, and Yldan's floor joined both ways (each fails on the maps before). - City gate (held-out walks, baseline 5): GAME Undercity 19 -> 3, Thunder Bluff 15 -> 1, Darnassus 20 -> 12; WALK 21 -> 2, 15 -> 1, 22 -> 11; no city worse.
…players take in Thunder Bluff and Darnassus - forge nav pack writes each lift landing's `ride`: the ride and the average wait for the car, from the client's TransportAnimation (the Undercity's lifts 7.6 s, Thunder Bluff's, Freewind Post's and the Great Lift 20.4 s, Gnomeregan's 11.9 s, the Cauldron's cars 29.9 and 42.7 s); Path.lua prices a ride at those seconds at run speed instead of a flat 25 s (kept for a landing without one). - Darnassus drop joins under the low-traffic rule (verified fall, never lethal, 80% of passers and 10+ people): the Temple of the Moon's balcony (all 41 recorded players who leave it downward drop off it; the falling flag on 5 of the 14 who leave Tyrande's spot) and the Cenarion Enclave tree's middle floor (11 of 11 at that edge, 13 of 14 who leave the floor downward). - Step joins where players step across a threshold neither map joins (Thunder Bluff: by Pala's inn, 17 players; two more, 8 and 7), the Warrior's Terrace steps in Darnassus (5); the Undercity's east ledge join left out (it joined a ledge the Trade Quarter's walk to the south lift starts from). - Tests: lift_rides on the Undercity's and Thunder Bluff's keyframes; a ride priced at its landing's seconds.
…Mesh's candidates, checked against the recordings); the Undervator test prices its ride at its own time
…e city The step at 40.83, 49.01 (z 51, 5 recorded players) joined the ground the city was built over, which lies under its streets and is joined to the world only far away, to the canal side: a walk from that buried ground found a 620 yd way out instead of none (nav_maps' walk from ground joined only far away). The other Stormwind steps stay; maps repacked (Polestar_Nav_EK parts 11 and 12).
fitzforge
force-pushed
the
city/lifts-uc-tb-darn
branch
from
November 18, 2026 04:59
683dcf3 to
e588aec
Compare
…2/int # Conflicts: # addon/Polestar_Nav/PACK.json
…itals' step joins The walk out of the Commons without a height expands everything its start reaches in the city's cluster; the step joins add 4 floors and 41 arcs there, 49,231 -> 50,218 expansions for the same 153 yd path (no new ground outside the city: the walks onto the mountain over it are unchanged). Limit 50,000 -> 51,000.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Walking-map joins for the Undercity, Thunder Bluff and Darnassus, from the ways recorded players walk, and each lift ride priced at its own time. On feature/city-paths with #2916 (city/joins-steps, head ef25187) merged in: it uses its
"strict": true. Merge order: #2916, then #2911, then this (one Undercity lift test here passes only with #2911, below).What changes for players
Lift rides priced at their own time
forge nav packnow writes each lift landing'sride: the ride plus the average wait for the car, from the client's lift animation (TransportAnimation): the Undercity's lifts 7.6 s, Thunder Bluff's, Freewind Post's and the Great Lift 20.4 s, Gnomeregan's 11.9 s, the Cauldron's cars 29.9 and 42.7 s. The router prices a ride at those seconds at run speed instead of a flat 25 s (kept for a landing without one). The Undervator test in nav-maps (polestars_maps_on_the_engine_…) asserted the old price (the ride at least 12 s); it now checks the walk is the two landings' walks plus the Undervator's 7.6 s.Drops (for Fitz)
None is lethal (the largest, 28 yd, is about a quarter of full health).
How the joins were found
Held-back players (1 in 5, never used for trails) are the test; the joins come from the other players' walks: each walk that fails on the shipped maps (no walk, or 1.3x and 40+ yd round) was routed from both ends along its own route, and the gap between the two reaches is the missing way. A join is kept where our walking grid walks the gap and recorded players walk it (counts in each entry). Several gaps were ones the maps "already make" by a short way round (an arched bridge cut at its crest meets only down at the canal): those joins are
"strict": true. Six step joins (Thunder Bluff 4, Darnassus 2) are CityMesh's candidates that passed the recordings check (5+ training players stepping through, both ends on walked floors); three more of those candidates the walking maps already make were left out (they changed nothing).Gate (
nav city gate, held-out walks, against the feature tip with #2916:gate-pr2916.json)Ironforge, Stormwind and Orgrimmar: no joins and no lifts from this PR. PASS: no counted arm worse in any city; one walk newly failing (Darnassus 51, GAME, below). The six step joins changed no gate walk (Thunder Bluff and Darnassus gated with and without them: the same walks, the same yards).
With #2911 merged (
--policy a2, the gate run from the feature tip with city/floor merged in, so the reach and the 5-yd start rule are both in), against the #2916 maps with #2911's router:PASS; Darnassus 51 newly failing in GAME as below. Under a2, Undercity 144 and Darnassus 25 and 66 pass (the goal takes the trail floor), and Darnassus 99 fails as "under the city": the walk to the Sentinel ends on the right floor, 584 yd for the players' 507, but runs 10+ yd on ground under a walked terrace near (53.6, 42.1).
The ones left, each explained:
Broad eval (
nav eval broad, the 2,000 pairs, against the #2916 maps)Run on #2916's previous head (1fde2b5) with and without this PR; its new head only drops one Stormwind step, away from every pair that changes here.
Routed 98.7% = 98.7%, no pair routed in one and not the other; detour, drop, underground and steep rows unchanged (falls over 15 yd in a segment 69.7 → 69.8%). 7 of 2,000 pairs change, all through the Undercity or Thunder Bluff's lifts:
None of the pairs passes the Great Lift, Freewind Post, Gnomeregan or the Cauldron. Search times: median 255 → 266 ms, p95 805 → 786 ms (same machine load).
Checks
cargo test -p forge-navpasses (the golden pack unchanged).forge-addontestnav and lift tests: 711 pass, 1 fails:nav_e2e::lifts_in_the_trade_quarter_by_the_south_lift_…(the player's followed floor there reads Leffe's pocket at -47 under the Trade Quarter's -43; the Undercity joins now join -47, so the walk from it goes round, 196 yd). Passes with Capitals: walks never planned without a height, no retry without the goal's (#2860) #2911 merged (its search starts on the trail floor within 5 yd, and the Undercity counts as a capital): start -43, 67 yd, checked twice on a scratch merge, with all 28 Undercity tests.forge nav pack --leffe, grid 1.60.1.70532, date 2026-11-16.Model and tool: Claude Opus (omp).