Repository navigation
Conversation
fitzforge
added a commit
that referenced
this pull request
Nov 18, 2026
…ar its start height, then with none - Mirrors CityFloor's Walk.lua (#2911): from.floors = [z] with reach 10, then no start height.
Merged
4 of 5 tasks
fitzforge
marked this pull request as ready for review
November 18, 2026 02:46
7 tasks done
|
Other pull requests for the same issue
Please compare with them before going further. If one already covers the issue, close this one or offer the part it is missing there. One of them is merged, crediting whoever helped (CONTRIBUTING.md, "Before you start"). |
4 of 5 tasks
…goal's (#2860) - Walk.lua: in the six capitals an unknown floor is seeded from the NPC beside the player (Nav/NpcFloor.lua: talked to or targeted, else the newest nameplate, within 15 s and 30 yd, ambiguous spawns skipped) and the trail floor (Path.TrailFloor); a goal without a height ends on the trail floor at it. - A goal there keeps its height: searched with the router's reach (10 yd), never asked again without it; a walk that ends short of the goal's floor, or none, says "The last steps here aren't mapped". The measure and later walks alike. - Path.lua: to.reach / from.reach (runAny, runManyReach): the nearest surface on the goal's level within reach that a walk reaches, job.reached. nav eval's harness forwards reach and reports reached.
…height TravelData's taxiZ (TaxiNodes' height, written by forge's travel build) gives each flight point the floor its flight lands on; Walk.lua takes it for 30 s within 20 yd of a landing in a capital (the trails walk Thunder Bluff's tower top and the ground under it alike). Landings are seen from the taxi state, TakeTaxiNode, and control given back 100+ yd from where it was lost. Tests: the city tests settle each case.
…s near it before none
A trail's or an NPC's height can be a counter's top over the floor beside it (Ironforge's vendors): from
from.floors = { it } the walk is found, where no start height in Ironforge starts on the mountain. nav eval's
harness takes a route's floors.
…yd; the trail floor only within 4 yd of an NPC's or landing's height An Undercity Guardian at the bank also stands on the Ruins 98 yd over it, 24 yd away: within 30 yd its spawns span two levels and said nothing; the player who opened its window stood within interact range. With a height to go by, the trails' busiest level within 10 yd can be another one (the Undercity's ring 5 yd under Harbinger Balthazad's platform): the trail floor then only refines a height within 4 yd.
fitzforge
force-pushed
the
city/floor
branch
from
November 18, 2026 03:48
d3a200b to
bf50b8e
Compare
…from the trails With the trail layer the player's floor at the tram's entrance is known, so the plan follows the recorded path out of the hall first (a hand-made leg) and the first searched walk starts at its end, still on the city's guarded ground; the test reads that walk.
4 of 5 tasks
…thin 5 yd of it Leffe's maps hold a pocket surface at -47 under the Undercity's Trade Quarter walkway at -43 (2 recorded players against 75); the floor followed there reads the pocket and the walk to the south lift went 197 yd round. The follower keeps what it reads; the search starts where people walk.
fitzforge
marked this pull request as draft
November 18, 2026 04:19
Merged
4 tasks done
…s read as Tirisfal Glades) The zone a point under Tirisfal's ground reads is Tirisfal's (1420), so none of the capital rules ran in the Undercity (CityLifts2). A point in the Undercity's map frame counts; the other capitals are told by their zone.
fitzforge
added a commit
that referenced
this pull request
Nov 18, 2026
nav city gate: a2's GAME start settles on the trail floor within 5 yd (#2911's city.Settle)
… (the Undercity is a capital)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase A of the city pathing work: walks in the six capitals are never planned without a height, and a goal there is never asked again without its height.
What changes for players
How
Nav/Walk.lua(city): in a capital (Travel.ZoneOf), an unknown floor is seeded on the read surface nearest the hint: landing height (30 s, 20 yd), else the NPC's spawn height, withPath.TrailFloor(map, x, y, 4, near)on that level, elseTrailFloor(…, 4). Hints only seed an unknown floor: a floor followed in through a gate keeps. A goal without a height gets the trail floor at it. A goal with a height getsto.reach = 10and no second search without it, in the arrow's search, the probe, the later legs and the planner's measure (a measure that finds nothing keeps the straight estimates; the walk is never marked unreachable).Nav/NpcFloor.lua(new): NPC sightings, 15 s: the NPC whose window was opened (its spawns within 10 yd), else the one targeted, else the newest moused over or in a nameplate (spawns within 30 yd); an NPC with spawns more than 10 yd apart in height there says nothing. With such a height (or a landing's), the trail floor counts only within 4 yd of it. The Codex's spawns, read only when it is loaded.from.floors) before none (a trail's or NPC's height can be a counter's top; none starts on Ironforge's mountain).Routing/Path.lua:to.reach(runAny) andfrom.reach(runManyReach) – the nearest surface on the point's level within reach that a walk reaches,job.reached. Six tries, candidates within a cell of a tried one skipped.taxiZ(TaxiNodes' height per node) into TravelData.lua; Travel.lua puts it on each node.reach(route and batch) andreverse(batch), and reportsreached.Tests (fail before, pass after)
Before (feature/city-paths) 8 of the 9 new tests fail; the gate-boundary one is a guard and passes on both.
city_a1_*,city_a2_*,city_a3_*,city_after_a_flight_lands_*,city_walking_in_through_a_gate_*ironforge_the_walk_to_the_cooking_trainer_at_his_height_with_the_reach_*_2860(real engine, shipped maps: walk and reversed measure)taxi_z_lists_each_node_s_landing_height_by_id_*Gate (held-out walks)
Gate baseline 5 (feature/city-paths' router, today's retry, fresh NPC spawn heights; ends anchored; walks without an end height judged at their nearest point's height) against this branch with
--policy a2, same gate commit. PASS: no counted arm worse in any city, nothing newly failing.The gate's WALK baseline is being re-run with these floor rules mirrored (baseline 6); I'll post that table here too.
Model and tool: Claude Opus (omp).