Skip to content

Capitals: walks never planned without a height, no retry without the goal's (#2860) - #2911

Draft
fitzforge wants to merge 10 commits into
feature/city-pathsfrom
city/floor
Draft

fitzforge wants to merge 10 commits into
feature/city-pathsfrom
city/floor

Conversation

@fitzforge

@fitzforge fitzforge commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Phase A of the city pathing work: walks in the six capitals are never planned without a height, and a goal there is never asked again without its height.

What changes for players

  • After a loading screen, a hearth or a flight into a capital, the arrow no longer starts its walk on the ground under Stormwind's or Orgrimmar's streets or on the mountain over Ironforge. It takes the floor from, in order: the flight point you just landed at, the NPC you just talked to or targeted (else one moused over or in a nameplate), and where players walk (the trail floor, once the trail layer lands).
  • A trainer or vendor whose last steps the walking maps don't reach (Ironforge's cooking trainer, Ironforge Path Routing #2860) now gets a walk to the nearest spot on their level, with "The last steps here aren't mapped" under the arrow. Before, the walk was asked again without the NPC's height and went out of Ironforge's gate and over the mountain: 3,515 yd for a 356 yd walk (the travel line's 8:20 came from the same retry in the planner's measure).

How

  • Nav/Walk.lua (city): in a capital (Travel.ZoneOf), an unknown floor is seeded on the read surface nearest the hint: landing height (30 s, 20 yd), else the NPC's spawn height, with Path.TrailFloor(map, x, y, 4, near) on that level, else TrailFloor(…, 4). Hints only seed an unknown floor: a floor followed in through a gate keeps. A goal without a height gets the trail floor at it. A goal with a height gets to.reach = 10 and no second search without it, in the arrow's search, the probe, the later legs and the planner's measure (a measure that finds nothing keeps the straight estimates; the walk is never marked unreachable).
  • Nav/NpcFloor.lua (new): NPC sightings, 15 s: the NPC whose window was opened (its spawns within 10 yd), else the one targeted, else the newest moused over or in a nameplate (spawns within 30 yd); an NPC with spawns more than 10 yd apart in height there says nothing. With such a height (or a landing's), the trail floor counts only within 4 yd of it. The Codex's spawns, read only when it is loaded.
  • In a capital, a start height whose walk finds nothing is asked from the surfaces within 10 yd of it (from.floors) before none (a trail's or NPC's height can be a counter's top; none starts on Ironforge's mountain).
  • Routing/Path.lua: to.reach (runAny) and from.reach (runManyReach) – the nearest surface on the point's level within reach that a walk reaches, job.reached. Six tries, candidates within a cell of a tried one skipped.
  • Landing heights: forge's travel build writes taxiZ (TaxiNodes' height per node) into TravelData.lua; Travel.lua puts it on each node.
  • nav eval's harness forwards reach (route and batch) and reverse (batch), and reports reached.
  • Arrow: "The last steps here aren't mapped" under the label (all nine languages).

Tests (fail before, pass after)

Before (feature/city-paths) 8 of the 9 new tests fail; the gate-boundary one is a guard and passes on both.

  • nav-spf city_a1_*, city_a2_*, city_a3_*, city_after_a_flight_lands_*, city_walking_in_through_a_gate_*
  • nav-reported ironforge_the_walk_to_the_cooking_trainer_at_his_height_with_the_reach_*_2860 (real engine, shipped maps: walk and reversed measure)
  • forge-data taxi_z_lists_each_node_s_landing_height_by_id_*

Gate (held-out walks)

Gate baseline 5 (feature/city-paths' router, today's retry, fresh NPC spawn heights; ends anchored; walks without an end height judged at their nearest point's height) against this branch with --policy a2, same gate commit. PASS: no counted arm worse in any city, nothing newly failing.

City trips GAME before GAME after WALK before WALK after
Stormwind 200 12 12 12 11
Orgrimmar 200 24 24 26 26
Ironforge 200 10 8 10 6
Thunder Bluff 150 15 15 15 15
Darnassus 100 20 20 22 19
Undercity 150 19 19 21 18
all 1000 100 98 106 95
  • GAME fixed: Ironforge 66 and 178 (Ironforge Path Routing #2860, Daryl Riknussun).
  • WALK fixed: Ironforge 66, 110, 123, 178 (110 and 123: a vendor's counter top as the start height; the floors retry finds the walk), Stormwind 51, Darnassus 25, 66, 92, Undercity 19, 34, 144 (19: an Undercity Guardian whose window was opened counts only its spawn beside the player, not the one on the Ruins 98 yd over it; 34: the trail floor kept only within 4 yd of an NPC's height).
  • What's left is the maps (shops and platforms the walking maps don't join: CityJoins), detours, and the Wizard's Sanctum chamber (portal only).

The gate's WALK baseline is being re-run with these floor rules mirrored (baseline 6); I'll post that table here too.

Model and tool: Claude Opus (omp).

fitzforge added a commit that referenced this pull request Nov 18, 2026
…ar its start height, then with none

- Mirrors CityFloor's Walk.lua (#2911): from.floors = [z] with reach 10, then no start height.
@fitzforge
fitzforge marked this pull request as ready for review November 18, 2026 02:46
@github-actions

Copy link
Copy Markdown

Other pull requests for the same issue

Please compare with them before going further. If one already covers the issue, close this one or offer the part it is missing there. One of them is merged, crediting whoever helped (CONTRIBUTING.md, "Before you start").

@github-actions github-actions Bot added the overlap Another open pull request addresses the same issue label Nov 18, 2026
…goal's (#2860)

- Walk.lua: in the six capitals an unknown floor is seeded from the NPC beside the player (Nav/NpcFloor.lua: talked
  to or targeted, else the newest nameplate, within 15 s and 30 yd, ambiguous spawns skipped) and the trail floor
  (Path.TrailFloor); a goal without a height ends on the trail floor at it.
- A goal there keeps its height: searched with the router's reach (10 yd), never asked again without it; a walk that
  ends short of the goal's floor, or none, says "The last steps here aren't mapped". The measure and later walks alike.
- Path.lua: to.reach / from.reach (runAny, runManyReach): the nearest surface on the goal's level within reach that a
  walk reaches, job.reached. nav eval's harness forwards reach and reports reached.
…height

TravelData's taxiZ (TaxiNodes' height, written by forge's travel build) gives each flight point the floor its flight
lands on; Walk.lua takes it for 30 s within 20 yd of a landing in a capital (the trails walk Thunder Bluff's tower top
and the ground under it alike). Landings are seen from the taxi state, TakeTaxiNode, and control given back 100+ yd
from where it was lost. Tests: the city tests settle each case.
…s near it before none

A trail's or an NPC's height can be a counter's top over the floor beside it (Ironforge's vendors): from
from.floors = { it } the walk is found, where no start height in Ironforge starts on the mountain. nav eval's
harness takes a route's floors.
…yd; the trail floor only within 4 yd of an NPC's or landing's height

An Undercity Guardian at the bank also stands on the Ruins 98 yd over it, 24 yd away: within 30 yd its spawns span two
levels and said nothing; the player who opened its window stood within interact range. With a height to go by, the
trails' busiest level within 10 yd can be another one (the Undercity's ring 5 yd under Harbinger Balthazad's
platform): the trail floor then only refines a height within 4 yd.
…from the trails

With the trail layer the player's floor at the tram's entrance is known, so the plan follows the recorded path out of
the hall first (a hand-made leg) and the first searched walk starts at its end, still on the city's guarded ground; the
test reads that walk.
…thin 5 yd of it

Leffe's maps hold a pocket surface at -47 under the Undercity's Trade Quarter walkway at -43 (2 recorded players
against 75); the floor followed there reads the pocket and the walk to the south lift went 197 yd round. The follower
keeps what it reads; the search starts where people walk.
…s read as Tirisfal Glades)

The zone a point under Tirisfal's ground reads is Tirisfal's (1420), so none of the capital rules ran in the
Undercity (CityLifts2). A point in the Undercity's map frame counts; the other capitals are told by their zone.
fitzforge added a commit that referenced this pull request Nov 18, 2026
… trail floor within 5 yd of it (Walk.lua's city.Settle)

- Mirrors #2911's a1d79ae: a search from a followed floor in a capital starts on the trail floor (TrailFloor reach 4, near the floor) when that lies within 5 yd of it, else on the floor.
fitzforge added a commit that referenced this pull request Nov 18, 2026
nav city gate: a2's GAME start settles on the trail floor within 5 yd (#2911's city.Settle)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

overlap Another open pull request addresses the same issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant