Skip to content

fix(tests): enhance & un-skip Amsterdam ported static create-OOG tests (Pt. 2b) - #3320

Draft
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:ported-static-pt2b
Draft

fix(tests): enhance & un-skip Amsterdam ported static create-OOG tests (Pt. 2b)#3320
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:ported-static-pt2b

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Second slice of the Part 2 ported static split (chain in #3264): the CREATE/initcode OOG-budget families — stCreateTest remainder, stInitCodeTest, the empty-contract-with-storage consolidations, the EIP-150 create/delegate/oog cascade, name-registrator, stStaticCall create/ask, and the stBadOpcode CREATE gas searches. 25 files, 44 skip-list entries un-skipped (130 → 86).

Notables: EIP-8037's code-deposit regular cost is only the keccak word cost — the 200/byte constant is pre-8037, fatal for one-gas-short deposit boundaries; a prefunded create-transaction target provably pays no top-frame new-account state gas; create_e_contract_create_ne_contract_in_init_oog_tr asserted a child account at a vacuous nonce-0 address — restored against the legacy filler.

Every touched test fills green across its full valid_from range, and the whole tests/ported_static/ tree fills green on Amsterdam at this slice. Stacked on Pt. 2a (#3264); the diff includes it until it merges.

Related Issues or PRs

Follow-up to #3215/#3264.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (f1aa970) to head (d2df7aa).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3320      +/-   ##
===================================================
+ Coverage            93.50%   93.52%   +0.02%     
===================================================
  Files                  624      624              
  Lines                37070    37070              
  Branches              3394     3394              
===================================================
+ Hits                 34661    34669       +8     
+ Misses                1653     1649       -4     
+ Partials               756      752       -4     
Flag Coverage Δ
unittests 93.52% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tests Area: Consensus tests. C-chore Category: chore

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant