fix(tests): enhance & un-skip Amsterdam ported static create-OOG tests (Pt. 2b) - #3320
Draft
spencer-tb wants to merge 1 commit into
Draft
fix(tests): enhance & un-skip Amsterdam ported static create-OOG tests (Pt. 2b)#3320spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
This was referenced Aug 5, 2026
Draft
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3320 +/- ##
===================================================
+ Coverage 93.50% 93.52% +0.02%
===================================================
Files 624 624
Lines 37070 37070
Branches 3394 3394
===================================================
+ Hits 34661 34669 +8
+ Misses 1653 1649 -4
+ Partials 756 752 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
force-pushed
the
ported-static-pt2b
branch
from
August 5, 2026 15:58
7a45530 to
d2df7aa
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Second slice of the Part 2 ported static split (chain in #3264): the CREATE/initcode OOG-budget families — stCreateTest remainder, stInitCodeTest, the empty-contract-with-storage consolidations, the EIP-150 create/delegate/oog cascade, name-registrator, stStaticCall create/ask, and the stBadOpcode CREATE gas searches. 25 files, 44 skip-list entries un-skipped (130 → 86).
Notables: EIP-8037's code-deposit regular cost is only the keccak word cost — the 200/byte constant is pre-8037, fatal for one-gas-short deposit boundaries; a prefunded create-transaction target provably pays no top-frame new-account state gas;
create_e_contract_create_ne_contract_in_init_oog_trasserted a child account at a vacuous nonce-0 address — restored against the legacy filler.Every touched test fills green across its full
valid_fromrange, and the wholetests/ported_static/tree fills green on Amsterdam at this slice. Stacked on Pt. 2a (#3264); the diff includes it until it merges.Related Issues or PRs
Follow-up to #3215/#3264.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture