chore(tests): remove the emptied Amsterdam ported static skip list and its conftest (Pt. 2b) - #3319
Closed
spencer-tb wants to merge 25 commits into
Closed
chore(tests): remove the emptied Amsterdam ported static skip list and its conftest (Pt. 2b)#3319spencer-tb wants to merge 25 commits into
spencer-tb wants to merge 25 commits into
Conversation
…k-derived thresholds
… and warm stipend boundary
…rmth ported tests
…ets and boundaries
…hance-ported-test
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3319 +/- ##
===================================================
- Coverage 93.50% 93.21% -0.29%
===================================================
Files 624 624
Lines 37070 37070
Branches 3394 3394
===================================================
- Hits 34661 34555 -106
- Misses 1653 1723 +70
- Partials 756 792 +36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Draft
2 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 2b of the ported static enhancement effort: with every entry un-skipped in Pt. 2a (#3264), remove the now-empty
amsterdam_skip_list.txtand theconftest.pymachinery that applied it, and drop the skip-list references from theenhance-ported-testskill.Stacked on #3264 — only the final
chore(tests)commit is new here; the rest disappears once Pt. 2a merges and this is rebased.Related Issues or PRs
Follow-up to #3264 (Pt. 2a). Completes the skipped-ported-static burn-down item in #3217.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture