fix(tests): enhance & un-skip Amsterdam ported static SSTORE, refund & misc tests (Pt. 2c) - #3321
Draft
spencer-tb wants to merge 1 commit into
Draft
fix(tests): enhance & un-skip Amsterdam ported static SSTORE, refund & misc tests (Pt. 2c)#3321spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
This was referenced Aug 5, 2026
Draft
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3321 +/- ##
===================================================
+ Coverage 93.50% 93.52% +0.02%
===================================================
Files 624 624
Lines 37070 37070
Branches 3394 3394
===================================================
+ Hits 34661 34671 +10
+ Misses 1653 1648 -5
+ Partials 756 751 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…& misc tests (Pt. 2c)
spencer-tb
force-pushed
the
ported-static-pt2c
branch
from
August 5, 2026 15:58
2349a78 to
cf739e7
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Third slice of the Part 2 ported static split (chain in #3264): SSTORE, refund, and miscellaneous families — stSStoreTest plus the gas_cost SSTORE case, refund600 and the refund-cap formula, stSolidityTest, stTransactionTest, attack-replay + callcode-suicide, double-selfdestruct-touch, exp-empty / homestead-oog / create-warmth, and gas-price-for-codes + memory OOG. 21 files, 37 skip-list entries un-skipped (86 → 49).
Notables: the EIP-3529 refund-cap base needs
return_cost_deducted_prior_execution=True; a post-call SSTORE on a 1/64 retention needs the sentinel-prewrite recipe (EIP-2200 stipend vs retention); the Ropsten attack-replay loop drains after 22 children instead of 123 under EIP-8037 with the revised EIP-8038 pricing (split post pins both counts); reservoir-less sub-calls pay state gas from their own grant, and a failed frame forfeits the whole grant.Every touched test fills green across its full
valid_fromrange, and the wholetests/ported_static/tree fills green on Amsterdam at this slice. Stacked on Pt. 2b (#3320); the diff includes the earlier slices until they merge.Related Issues or PRs
Follow-up to #3215/#3264. Part of the burn-down in #3217.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture