Skip to content

fix(tests): enhance & un-skip Amsterdam ported static depth-recursion tests (Pt. 2a) - #3264

Open
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:ported-static-enhance-pt2
Open

fix(tests): enhance & un-skip Amsterdam ported static depth-recursion tests (Pt. 2a)#3264
spencer-tb wants to merge 1 commit into
ethereum:forks/amsterdamfrom
spencer-tb:ported-static-enhance-pt2

Conversation

@spencer-tb

@spencer-tb spencer-tb commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

First slice of the Part 2 ported static enhancement (#3215 follow-up), split into four PRs for reviewability. This one carries the depth-recursion families: the *1024_oog / ab_acalls / call_recursive_bomb3 recursion pins, the 63/64 ask-family, and the transaction64_rule consolidation. 18 files, 23 skip-list entries un-skipped (153 → 130).

Each recursion test derives its expected OOG-terminated depth with a fork-derived recurrence (per-level costs from opcode composites, EIP-150 clamping, failed-frame grant forfeiture, journal rollback), validated against every ported Cancun pin exactly before predicting Amsterdam — where depths collapse (e.g. 134 → 37) under EIP-8037's state costs. Depth-1024 is unreachable under 63/64 attenuation, so call-loop tests keep a named budget with per-era pinned counts. Under the revised EIP-8038 storage pricing (#3293) call_recursive_bomb3's top level can no longer afford its flag store at the ported budget, so its model now pins a wholesale revert.

Every touched test fills green across its full valid_from range, and the whole tests/ported_static/ tree fills green on Amsterdam at this slice. Chain: this PR → Pt. 2b (#3320) → Pt. 2c (#3321) → Pt. 2d (#3322, drops the emptied skip list + conftest).

Related Issues or PRs

Follow-up to #3215. Part of the skipped-ported-static burn-down in #3217; the EIP-8037 fail tracker #2601 closes with Pt. 2d.

Checklist

  • Ran fast static checks to avoid CI fails, see Code Standards & Verifying Changes: just static
  • PR title has the form <type>(<area>): <title>, where <type> and <area> come from an appropriate C-<type>, respectively A-<area>, label. The title should match the target squash commit message.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.52%. Comparing base (f1aa970) to head (489254d).
⚠️ Report is 1 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #3264      +/-   ##
===================================================
+ Coverage            93.50%   93.52%   +0.02%     
===================================================
  Files                  624      624              
  Lines                37070    37070              
  Branches              3394     3394              
===================================================
+ Hits                 34661    34669       +8     
+ Misses                1653     1649       -4     
+ Partials               756      752       -4     
Flag Coverage Δ
unittests 93.52% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencer-tb
spencer-tb force-pushed the ported-static-enhance-pt2 branch from c8fff52 to 489254d Compare August 5, 2026 15:46
@spencer-tb spencer-tb changed the title fix(tests): enhance & un-skip Amsterdam ported static tests (Pt. 2a) fix(tests): enhance & un-skip Amsterdam ported static depth-recursion tests (Pt. 2a) Aug 5, 2026
@LouisTsai-Csie
LouisTsai-Csie self-requested a review August 6, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant