fix(tests): enhance & un-skip Amsterdam ported static depth-recursion tests (Pt. 2a) - #3264
Open
spencer-tb wants to merge 1 commit into
Open
fix(tests): enhance & un-skip Amsterdam ported static depth-recursion tests (Pt. 2a)#3264spencer-tb wants to merge 1 commit into
spencer-tb wants to merge 1 commit into
Conversation
12 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3264 +/- ##
===================================================
+ Coverage 93.50% 93.52% +0.02%
===================================================
Files 624 624
Lines 37070 37070
Branches 3394 3394
===================================================
+ Hits 34661 34669 +8
+ Misses 1653 1649 -4
+ Partials 756 752 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
marked this pull request as ready for review
July 30, 2026 08:15
This was referenced Jul 31, 2026
spencer-tb
force-pushed
the
ported-static-enhance-pt2
branch
from
August 5, 2026 15:14
bfb1242 to
c8fff52
Compare
Closed
2 tasks
spencer-tb
force-pushed
the
ported-static-enhance-pt2
branch
from
August 5, 2026 15:46
c8fff52 to
489254d
Compare
This was referenced Aug 5, 2026
Draft
LouisTsai-Csie
self-requested a review
August 6, 2026 12:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First slice of the Part 2 ported static enhancement (#3215 follow-up), split into four PRs for reviewability. This one carries the depth-recursion families: the
*1024_oog/ab_acalls/call_recursive_bomb3recursion pins, the 63/64 ask-family, and thetransaction64_ruleconsolidation. 18 files, 23 skip-list entries un-skipped (153 → 130).Each recursion test derives its expected OOG-terminated depth with a fork-derived recurrence (per-level costs from opcode composites, EIP-150 clamping, failed-frame grant forfeiture, journal rollback), validated against every ported Cancun pin exactly before predicting Amsterdam — where depths collapse (e.g. 134 → 37) under EIP-8037's state costs. Depth-1024 is unreachable under 63/64 attenuation, so call-loop tests keep a named budget with per-era pinned counts. Under the revised EIP-8038 storage pricing (#3293)
call_recursive_bomb3's top level can no longer afford its flag store at the ported budget, so its model now pins a wholesale revert.Every touched test fills green across its full
valid_fromrange, and the wholetests/ported_static/tree fills green on Amsterdam at this slice. Chain: this PR → Pt. 2b (#3320) → Pt. 2c (#3321) → Pt. 2d (#3322, drops the emptied skip list + conftest).Related Issues or PRs
Follow-up to #3215. Part of the skipped-ported-static burn-down in #3217; the EIP-8037 fail tracker #2601 closes with Pt. 2d.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture