Repository navigation
⚡ Bolt: Optimize event-stream media type parsing - #316
Conversation
Replaced mime.ParseMediaType with strings.HasPrefix check for text/event-stream to prevent memory allocations in the proxy response hot path. Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Replaced
mime.ParseMediaTypewithstrings.HasPrefix(strings.ToLower(...), "text/event-stream")for checking event stream responses.🎯 Why:
mime.ParseMediaTypeallocates memory during parsing. Since we are in the hot path of handling proxy responses and only care abouttext/event-stream, doing a prefix check avoids allocations.📊 Impact: Reduces memory allocations during proxy response handling.
🔬 Measurement: Run standard benchmark profiling or monitor memory allocation overhead before and after the change in the client proxy processing responses.
PR created automatically by Jules for task 1179457867914622642 started by @callmeradical