Skip to content

⚡ Bolt: [performance improvement] - #313

Closed
callmeradical wants to merge 1 commit into
mainfrom
bolt-perf-proxy-mime-6720432673784249618
Closed

callmeradical wants to merge 1 commit into
mainfrom
bolt-perf-proxy-mime-6720432673784249618

Conversation

@callmeradical

Copy link
Copy Markdown
Owner

💡 What: Replaced mime.ParseMediaType with a lowercased strings.HasPrefix check in the MCP client proxy response writer. Also removed the unused mime import.
🎯 Why: mime.ParseMediaType performs allocations (maps and string splits) which adds measurable overhead to hot paths like the JSON-RPC response proxy loop.
📊 Impact: Reduces memory allocations per-response during streaming.
🔬 Measurement: Profile the writeResponse function; observe zero allocations for content type checking.


PR created automatically by Jules for task 6720432673784249618 started by @callmeradical

…MediaType

Replaced mime.ParseMediaType with a lowercased strings.HasPrefix check in the MCP client proxy response writer, avoiding memory allocations per-response during stream relaying. Cleaned up the now-unused mime import in proxy.go. Added a critical performance learning to the bolt journal.

Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@callmeradical

Copy link
Copy Markdown
Owner Author

Closing as a duplicate/superseded Jules proposal. The canonical implementation is merged in #316.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as a duplicate/superseded Jules proposal. The canonical implementation is merged in #316.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant