Repository navigation
⚡ Bolt: [performance improvement] Remove mime.ParseMediaType allocation in proxy hot path - #315
callmeradical wants to merge 1 commit into
Conversation
Replaced `mime.ParseMediaType` with an allocation-free check using `strings.HasPrefix` combined with `strings.ToLower` and `strings.TrimSpace` for case-insensitive matching of `text/event-stream`. This removes unnecessary memory allocations and garbage collection pressure in the proxy's hot path for handling HTTP responses. Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as a duplicate/superseded Jules proposal. The canonical implementation is merged in #316. |
1 participant
💡 What: Replaced
mime.ParseMediaTypewith an allocation-free check usingstrings.HasPrefixcombined withstrings.ToLowerandstrings.TrimSpacefor case-insensitive matching oftext/event-stream.🎯 Why:
mime.ParseMediaTypecauses unnecessary memory allocations and garbage collection pressure in the proxy's hot path for handling HTTP responses when only checking for a specific content type prefix.📊 Impact: Removes memory allocations and reduces garbage collection pressure for every HTTP response processed by the proxy.
🔬 Measurement: Verified with
go test ./...andgo build ./...to ensure no regressions. The performance improvement can be measured by profiling memory allocations during a high volume of proxy requests.PR created automatically by Jules for task 7068172319543816985 started by @callmeradical