Skip to content

⚡ Bolt: Optimize JSON-RPC proxy payload parsing - #309

Closed
callmeradical wants to merge 1 commit into
mainfrom
bolt-optimize-content-type-matching-13712194356816598423
Closed

callmeradical wants to merge 1 commit into
mainfrom
bolt-optimize-content-type-matching-13712194356816598423

Conversation

@callmeradical

Copy link
Copy Markdown
Owner

💡 What: Replaced mime.ParseMediaType(resp.contentType) with strings.HasPrefix(resp.contentType, "text/event-stream") in the MCP client proxy hot path.
🎯 Why: mime.ParseMediaType performs parsing and multiple memory allocations (lowercasing strings, allocating parameter maps) on every single SSE response chunk. Because the proxy only cares about prefix-matching text/event-stream, a simple string prefix check eliminates this overhead and reduces GC pressure in a highly executed path.
📊 Impact: Reduces memory allocations and CPU overhead on every HTTP response processed by the proxy, speeding up streaming JSON-RPC delivery.
🔬 Measurement: Verify by running the test suite (go test ./...) to ensure SSE and normal responses are still routed correctly.


PR created automatically by Jules for task 13712194356816598423 started by @callmeradical

Replaced `mime.ParseMediaType` with `strings.HasPrefix` in the proxy
hot path to eliminate unnecessary memory allocations and string parsing
overhead during Server-Sent Events (SSE) processing.

Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@callmeradical

Copy link
Copy Markdown
Owner Author

Closing as a duplicate/superseded Jules proposal. The canonical implementation is merged in #316.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as a duplicate/superseded Jules proposal. The canonical implementation is merged in #316.

Understood. Acknowledging that this work is superseded by #316 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant