Repository navigation
⚡ Bolt: Optimize JSON-RPC proxy payload parsing - #309
callmeradical wants to merge 1 commit into
Conversation
Replaced `mime.ParseMediaType` with `strings.HasPrefix` in the proxy hot path to eliminate unnecessary memory allocations and string parsing overhead during Server-Sent Events (SSE) processing. Co-authored-by: callmeradical <822382+callmeradical@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as a duplicate/superseded Jules proposal. The canonical implementation is merged in #316. |
💡 What: Replaced
mime.ParseMediaType(resp.contentType)withstrings.HasPrefix(resp.contentType, "text/event-stream")in the MCP client proxy hot path.🎯 Why:
mime.ParseMediaTypeperforms parsing and multiple memory allocations (lowercasing strings, allocating parameter maps) on every single SSE response chunk. Because the proxy only cares about prefix-matchingtext/event-stream, a simple string prefix check eliminates this overhead and reduces GC pressure in a highly executed path.📊 Impact: Reduces memory allocations and CPU overhead on every HTTP response processed by the proxy, speeding up streaming JSON-RPC delivery.
🔬 Measurement: Verify by running the test suite (
go test ./...) to ensure SSE and normal responses are still routed correctly.PR created automatically by Jules for task 13712194356816598423 started by @callmeradical