feat(workspace): name tonight's first playable range on the map - #957
Conversation
The ready rehearsal board showed chords, cues, and clashes but never named the first playable span, so players still guessed whether a part would fit before the next section. Security Notes: no new filesystem, URL, subprocess, IPC, or model authority. Copy is derived from already-validated rehearsal analysis fields already rendered in the workspace.
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough첫 번째 유효 음역을 선택하는 유틸리티를 추가했습니다. Workspace에 첫 음역 확인 안내를 표시합니다. SectionRoadmap은 검증된 역할 음역만 표시합니다. 영어와 한국어 번역 및 관련 테스트를 추가했습니다. Changes음역 기반 리허설 안내
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to The new workspace guidance may display unintended text when a template contains an unknown inherited token, though the impact is localized to presentation and the PR remains mergeable with explicit owner follow-up. Sequence Diagram(s)sequenceDiagram
participant Workspace
participant firstRangeSqueeze
participant Localization
participant SectionRoadmap
Workspace->>firstRangeSqueeze: 활성 역할과 곡 데이터 전달
firstRangeSqueeze-->>Workspace: 검증된 첫 음역과 충돌 상태 반환
Workspace->>Localization: 상태별 안내 문자열 조회
Localization-->>Workspace: 번역된 안내 문구 반환
Workspace->>SectionRoadmap: 역할 음역 데이터 전달
SectionRoadmap->>Localization: 음역 라벨과 다음 행동 문구 조회
Localization-->>SectionRoadmap: 번역된 문자열 반환
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 88.89% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 9 functions across 5 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
opencode-agent
Bot
added
area: ui-ux
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The section card range row gated only on meaningfulRangeText, so an inverted or malformed span (e.g. E3-C#2) rendered as valid playable-range guidance while firstRangeSqueeze failed closed on the same data. Export the shared playableRange helper and gate the roadmap row on it so both surfaces reject non-pitch or low>high evidence identically.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
values[token] also resolves inherited members, so a {toString} token with no
matching value would render the inherited function source instead of keeping
the placeholder. Look up via hasOwnProperty and pin the regression with a
{toString}/{missingToken} test.
1 participant
Buyer-visible gap
The ready rehearsal workspace already shows chords, cues, setup notes, simplification, and overlap warnings, but it did not name the first playable span. The initial implementation also trusted typed runtime range structure too far: malformed/inverted note labels could become confident guidance and malformed song/section/role collections could crash the new callout boundary.
Product outcome
When analysis is ready, the map names tonight's first valid playable range and the next instrument check:
{role} sits {low}–{high} in {section}. Hear that clash on your instrument before the {section}.{role} sits {low}–{high} in {section}. Check that span on your instrument before the {section}.Section cards show the same valid span and next action. English and Korean copy stay in sync. Selecting a role limits the callout to that part.
Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9bd0915dae91c5ab0d54758d0b7475445bee94009feat/workspace-first-playable-rangeScope / trust boundary
nonesentinels are not notes, names, labels, ids, or warnings.Test-first repairs
Playable-range integrity
Fresh comparison with the existing Stem Lab range-integrity contract showed that the predecessor helper only checked for nonblank strings. Shared runtime range fields are strings, so
not-a-note–E3andE3–C#2could be presented as playable.b42cc90f3ed2f4a95b6b0224efe07b0079d56ae9adds selected-role regressions requiring malformed and inverted spans to produce no playable-range evidence.28f4f7bcb246df130f36672bd76d623d37b51ba6adds scientific-pitch parsing and chromatic low≤high validation.Runtime containment
Adversarial current-source review then found
firstRangeSqueeze()dereferencedsong.sections,section.roles, androle.rangedirectly. A runtime-corrupted analysis payload could therefore crash the ready workspace despite the documented fail-closed analysis-data boundary.2143fbf71ffc22d88ebc5545be4980b2f39331afadds malformed root/collection/member cases plus a fail-isolation case proving one malformed role must not erase a valid neighboring role.bd0915dae91c5ab0d54758d0b7475445bee94009validates runtime objects/collections before property authority, accepts textual evidence only from actual strings, isolates malformed entries, and preserves the existing valid demo/selected-role/clash behavior.The prior CodeRabbit replacement-token finding is resolved/outdated on current code.
Exact-current-head verification
Fresh repository workflows are dispatched for exact head
bd0915dae91c5ab0d54758d0b7475445bee94009: CI32356196475, build-baseline32356196512, release32356196620, SBOM32356196442, security-audit32356196551, aggregate Security Scan32356196622, SAST Semgrep32356196715, Bandit32356196529, and secret-scan-gate32356196621.At the latest refetch all nine are queued. Queued evidence is non-passing; no predecessor-head result transfers. The only visible inline review thread is resolved/outdated. No merge readiness is claimed from status-only or model-only evidence.
Dependency ownership
Canonical #783 exclusively owns the protected-base npm HIGH set (
pdfjs-dist/nanoid/undici). This branch does not copy, suppress, or restate that remediation. Any exact-head security failure must still be inspected at its job/log boundary before classification.Merge gate
Keep unmerged until one unchanged resulting exact head has every applicable repository and central CI/security/SAST/SBOM/supply-chain/coverage/review gate terminal-success, zero valid unresolved findings, exact required owned coverage/docstring evidence, a qualifying independent non-author last-push APPROVE, and ordinary protected-branch acceptance without bypass. Queued, pending, skipped, cancelled, failed, stale, predecessor-head, inherited protected-base, model-only, self/author, or status-only evidence is non-passing.
Summary by CodeRabbit
새로운 기능
버그 수정