feat(workspace): guide tonight's first verse on map and player - #947
Open
seonghobae wants to merge 10 commits into
Open
feat(workspace): guide tonight's first verse on map and player#947seonghobae wants to merge 10 commits into
seonghobae wants to merge 10 commits into
Conversation
Name the earliest labeled verse so the room can open the story line on the map or hear it from the player. Fail closed on intro, pre-chorus, chorus, bridge, outro, tag, pickup, stop, and handoff labels, and keep Hear behind a real seek callback.
Contributor
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
opencode-agent
Bot
added
area: ui-ux
…le names
The ko firstVerseBody template attached the subject particle directly to
the dynamic role name ("{role}이 ..."), which produces ungrammatical copy
for vowel-ending names such as 피아노 (피아노이). Restructure the template
to "{at} {section}에서 {role} 파트가 첫 소절을 잡습니다." so particles
always attach to the fixed noun 파트, matching the particle-safe callout
convention used across the workspace-first series, and update the main
callout test expectation accordingly.
# Conflicts: # CHANGELOG.md
# Conflicts: # AGENTS.md # CHANGELOG.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json
Collaborator
Author
|
Merged current develop into this branch: resolved shared-file conflicts by including both this feature's first-verse-line callout and the newly landed #957 playable-range work (Workspace.tsx keeps both imports; en/ko locales unioned with symmetric keys; AGENTS/CLAUDE/CHANGELOG unioned). No behavior dropped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product outcome
After analysis, the room can see tonight's first labeled verse and take one honest next action: open that story line on the renderer-owned map, or hear it from Player only when playback authority is supplied. Copy names the holding part when an active role is corroborated, the labeled verse, and the time so the room can learn the first line.
Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.56e5b81150fba328028c58b98052751a66c4d7ba.feat/workspace-first-verse-line.Product / trust boundary
versesection whose runtime window is an integer, non-negative, positive-duration interval bounded by sharedMAX_SECTION_TIME_SECONDS.intro,pre-chorus,chorus,bridge,outro,tag,pickup,stop,handoff, or an unlabeled first section.Test-first stale-completion repair
Fresh current-source review found that predecessor code normalized a malformed/missing runtime
song.idto""and keyed completion state by that value plus verse section/role/time. Two different runtime songs with invalid ids and the same verse tuple could therefore share the armed state.6125221ab28147ae45986e14b71ebd20e6ea5f1dadds a replacement-song regression: open a verse on song A, replace it with a distinct song B whose runtime id is alsonulland whose verse metadata is otherwise equal, and require B to render fresh guidance rather than inherited completion.a1f2c73834cd1268f598d2dffa0a29e55ed9d8c1stores the currentRehearsalSongobject in the completed-action receipt, resets onsongidentity change, and requires receipt/song identity equality before rendering armed guidance.d77924814b33c2977bd2ad331421b9bbad9b149frestores the production file's terminal newline without changing behavior.6f71d87091a3028de120051bf5876773fd4d12b4attempted to record the fix but exact commit verification found unintended release-history deletion; current56e5b81150fba328028c58b98052751a66c4d7barestores the predecessor release history and retains only the intended Unreleased fix entry. The bad intermediate tree is not current evidence.No dependency, lockfile, workflow, Rust, Python, model, network, filesystem, persistence, IPC, or credential authority is changed by this repair.
Distinct from neighboring first-action lanes
verseso the room can learn the first line.Exact-current-head verification state
Every predecessor-head workflow/review result is historical after the TDD chain above. Fresh repository workflows are dispatched for exact head
56e5b81150fba328028c58b98052751a66c4d7ba:ci32325633490;release32325633645;sbom32325633665;build-baseline32325633474;security-audit32325633530;Security Scan32325633496;SAST Semgrep32325633478;bandit32325633482; andsecret-scan-gate32325633551.At the latest refresh every one of those runs was queued. Queued evidence is non-passing. Inspect any terminal failure at exact job/log/checkout-SHA level before another mutation or rerun.
There are currently no formal reviews and no inline review threads on this exact head. Absence of findings is not approval.
Dependency and supply-chain routing
The JavaScript dependency-security baseline remains owned by canonical #783 and must not be duplicated or suppressed in this rehearsal-copy slice. Repository security failures may be attributed to that owner only after exact-current-head job/log inspection proves the same protected-base causal boundary.
Security notes
Untrusted rehearsal metadata remains data only. Runtime roots and collections are validated before access; section time windows are bounded; section-local identities and ranked activity are corroborated; renderer positions own navigation; Player playback remains explicit callback authority; copy interpolation runs once;
matchMediais read-only; and completion state fails closed when the runtime song object changes.Merge gate
APPROVEDreview.