feat(workspace): name tonight's first overlap on the map - #992
feat(workspace): name tonight's first overlap on the map#992seonghobae wants to merge 9 commits into
Conversation
Name the earliest owned clash, the corroborated holding part, and the section time so the room can clear the overlap together. Open moves to the renderer-owned map section. Do not invent a clash from groove, cue, setup, simplification, or range copy.
|
Warning Review limit reachedNext included review available in 2 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (21)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Re-review request for exact head |
# Conflicts: # AGENTS.md # CLAUDE.md # apps/desktop/src/features/workspace/Workspace.tsx # apps/desktop/src/locales/en/common.json # apps/desktop/src/locales/ko/common.json
|
Merged current develop into this branch: resolved shared-file conflicts by including both this feature's first-overlap callout and the newly landed #957 playable-range work (Workspace.tsx keeps both imports; en/ko locales unioned with symmetric keys; AGENTS/CLAUDE unioned). No behavior dropped. |
|
Queued @opencode-agent for PR #992 at head |
Product outcome
Name tonight's first overlap so the room can clear the clash together. The Open action moves to the matching rendered map section.
Design authority: workspace next-action pattern plus
docs/design-system/component-contract.md. Distinct from first-groove, first-simplification, first-range, and first-form-label work. This does not close #873 (measured register-overlap wiring).Current exact scope
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.feat/workspace-first-overlap.FirstOverlapCalloutnames the warned part when an active graph node corroborates it, the ownedoverlapWarningstext, the labeled section, and the time.groove, cue text,setupNote,simplification, range copy, or empty/whitespace warnings.파트가/파트 겹침) and localizes the section form label.Trust boundary
section.idis never DOM-ID authority. Navigation uses renderer child index under the song-structure region.behavior: "auto"when the OS requests it.Dependency ownership
Canonical #783 owns the protected-base JavaScript HIGH findings (
pdfjs-dist/nanoid/undici). This branch has no JavaScript dependency, lockfile, or vulnerability-suppression delta. Inherited npm HIGH must not be suppressed here.Merge gate
APPROVEDreview.Queued, pending, skipped-required, failed, predecessor-head, protected-base, author-only, model-only, status-only, or synthetic evidence is non-passing.