Skip to content

feat(workspace): name tonight's first overlap on the map - #992

Open
seonghobae wants to merge 9 commits into
developfrom
feat/workspace-first-overlap
Open

feat(workspace): name tonight's first overlap on the map#992
seonghobae wants to merge 9 commits into
developfrom
feat/workspace-first-overlap

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Product outcome

Name tonight's first overlap so the room can clear the clash together. The Open action moves to the matching rendered map section.

Design authority: workspace next-action pattern plus docs/design-system/component-contract.md. Distinct from first-groove, first-simplification, first-range, and first-form-label work. This does not close #873 (measured register-overlap wiring).

Current exact scope

  • Protected target: develop@acdbea6344fe1231c39535b575f4de35e4c607c9.
  • Branch: feat/workspace-first-overlap.
  • FirstOverlapCallout names the warned part when an active graph node corroborates it, the owned overlapWarnings text, the labeled section, and the time.
  • Open scrolls the renderer-owned song-structure section. Missing targets stay guidance-only and do not claim navigation completed.
  • Do not invent a clash from groove, cue text, setupNote, simplification, range copy, or empty/whitespace warnings.
  • Owned overlap text is rendered as a text node and is never rescanned as template syntax.
  • Korean copy keeps particle-safe role phrasing (파트가 / 파트 겹침) and localizes the section form label.

Trust boundary

  • Untrusted runtime song, section, time-range, role, overlap-warning, and part-graph metadata are accepted only as own data properties.
  • Inherited properties, accessors, sparse arrays, and arrays masquerading as records cannot establish a clash or a holding part.
  • Analysis section.id is never DOM-ID authority. Navigation uses renderer child index under the song-structure region.
  • The overlap hint is bounded to 180 Unicode code points without splitting a surrogate pair.
  • Reduced-motion map navigation uses behavior: "auto" when the OS requests it.

Dependency ownership

Canonical #783 owns the protected-base JavaScript HIGH findings (pdfjs-dist / nanoid / undici). This branch has no JavaScript dependency, lockfile, or vulnerability-suppression delta. Inherited npm HIGH must not be suppressed here.

Merge gate

Queued, pending, skipped-required, failed, predecessor-head, protected-base, author-only, model-only, status-only, or synthetic evidence is non-passing.


Open in Devin Review

Name the earliest owned clash, the corroborated holding part, and the
section time so the room can clear the overlap together. Open moves to
the renderer-owned map section. Do not invent a clash from groove, cue,
setup, simplification, or range copy.
@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 2 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 59a25878-e051-4d12-b7a1-b0de7976a9be

📥 Commits

Reviewing files that changed from the base of the PR and between 749511c and 691c071.

📒 Files selected for processing (21)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE.md
  • apps/desktop/src/features/workspace/FirstOverlapCallout.empty-a11y.test.tsx
  • apps/desktop/src/features/workspace/FirstOverlapCallout.particle.test.tsx
  • apps/desktop/src/features/workspace/FirstOverlapCallout.progress-persistence.test.tsx
  • apps/desktop/src/features/workspace/FirstOverlapCallout.reduced-motion.test.tsx
  • apps/desktop/src/features/workspace/FirstOverlapCallout.test.tsx
  • apps/desktop/src/features/workspace/FirstOverlapCallout.tsx
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/features/workspace/Workspace.tsx
  • apps/desktop/src/features/workspace/firstOverlap.inherited-metadata.test.ts
  • apps/desktop/src/features/workspace/firstOverlap.test.ts
  • apps/desktop/src/features/workspace/firstOverlap.ts
  • apps/desktop/src/i18n/index.test.ts
  • apps/desktop/src/i18n/index.ts
  • apps/desktop/src/locales/en/common.json
  • apps/desktop/src/locales/ko/common.json
  • docs/design-system/component-contract.md
  • docs/doctoring/reduced-motion-first-overlap-navigation.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@seonghobae

Copy link
Copy Markdown
Collaborator Author

Re-review request for exact head e09f4f8598c7816db2833be5ed99c21a3084037a: all required status contexts are green on this head (including coverage-evidence and security scans) and all review threads are resolved. @opencode-agent please review current head e09f4f8598c7816db2833be5ed99c21a3084037a and update the review decision.

# Conflicts:
#	AGENTS.md
#	CLAUDE.md
#	apps/desktop/src/features/workspace/Workspace.tsx
#	apps/desktop/src/locales/en/common.json
#	apps/desktop/src/locales/ko/common.json
@seonghobae

Copy link
Copy Markdown
Collaborator Author

Merged current develop into this branch: resolved shared-file conflicts by including both this feature's first-overlap callout and the newly landed #957 playable-range work (Workspace.tsx keeps both imports; en/ko locales unioned with symmetric keys; AGENTS/CLAUDE unioned). No behavior dropped.

devin-ai-integration[bot]

This comment was marked as resolved.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 new potential issues.

Open in Devin Review

Comment thread apps/desktop/src/features/workspace/FirstOverlapCallout.tsx
Comment thread apps/desktop/src/features/workspace/firstOverlap.ts
@opencode-agent

Copy link
Copy Markdown
Contributor

Queued @opencode-agent for PR #992 at head 691c0711c88eea067793ad0890fa1751348fecc2. Central exact-name Actions artifacts are the durable dispatch ledger; existing review workflows remain authoritative for the final verdict and failure evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant