Skip to content

Add CI that runs the test suite; consolidate dev dependencies - #12

Merged
CodeWithBehnam merged 1 commit into
mainfrom
claude/lucid-franklin-gsu7v4
Sep 30, 2026
Merged

CodeWithBehnam merged 1 commit into
mainfrom
claude/lucid-franklin-gsu7v4

Conversation

@CodeWithBehnam

Copy link
Copy Markdown
Owner

What does this PR do?

Closes #2.

  • New Tests workflow (.github/workflows/tests.yml) runs pytest on pushes to main and on pull requests:
    • ubuntu-latest, Python 3.10 and 3.12, with MLX's CPU build (mlx[cpu])
    • macos-14, Python 3.12, with the standard mlx wheel
  • pyproject.toml has one dev dependency list: [project.optional-dependencies].dev. Notebook-only packages move to the notebook extra, and [dependency-groups] is removed. uv users run uv sync --extra dev.
  • uv.lock regenerated. It still referred to the old package name whisper-mlx 0.5.0; no dependency versions changed.
  • CONTRIBUTING: uv alternative, note that tests run on Linux with mlx[cpu], branch from main (not master).

This is the first of ten PRs for issues #2–#11. Each later PR adds tests for its fix, so they all run under this workflow.

How was this tested?

  • Tested with audio file(s)
  • Ran existing tests (pytest): 14 passed in a fresh venv installed exactly as the workflow does (pip install -e ".[dev]" "mlx[cpu]")
  • Tested CLI (vayu audio.mp3)

Checked that mlx[cpu] wheels exist for Python 3.10 and 3.12 on manylinux. The macOS job is untested until it runs here: GitHub's hosted macOS runners may not give MLX GPU access. If it fails for that reason, I'll adjust it in this PR.

🤖 Generated with Claude Code

https://claude.ai/code/session_01TMXYMqgLAykqRApmbRfpTA


Generated by Claude Code

- New Tests workflow runs pytest on pushes to main and on pull requests:
  ubuntu-latest (Python 3.10, 3.12) with MLX's CPU build, and macos-14.
- Merge the two dev dependency lists: [project.optional-dependencies].dev
  is now the single source; notebook-only packages move to the notebook
  extra and [dependency-groups] is removed.
- Regenerate uv.lock (it still referenced the old whisper-mlx 0.5.0 name).
- CONTRIBUTING: uv alternative, Linux test note, branch from main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TMXYMqgLAykqRApmbRfpTA

Copy link
Copy Markdown
Owner Author

claude-review (Claude Code Review workflow) is red, but not because of this PR. The action installed and started fine, then the model call ended after 1.9 s with zero model usage and is_error: true. That pattern points to the CLAUDE_CODE_OAUTH_TOKEN repository secret failing to authenticate (expired or revoked). This PR doesn't touch claude-code-review.yml, and every job in the new Tests workflow passes (ubuntu 3.10 and 3.12, macos-14 3.12).

The fix can't come from a PR: regenerate the token (claude setup-token, or re-run /install-github-app) and update the secret under Settings → Secrets and variables → Actions. I'm re-running the job once to confirm.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI that runs the test suite; consolidate dev dependencies

2 participants