Follow the temperature schedule in batched fallback - #15
Merged
Merged
Conversation
Batched decoding always decoded at 0.0 and retried failing segments once at 1.0, whatever temperature the caller passed: temperature=0.0 still triggered a retry, the default schedule jumped straight to its noisiest step, and retried results were never re-checked. decode_batch_with_fallback now walks the same schedule as the one-window path, re-decoding only the segments that still fail at each step as one smaller batch. A single temperature means no fallback. The pass/fail check is shared by both paths. The test stub now numbers windows by their mel content so a re-decode maps back to the same window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TMXYMqgLAykqRApmbRfpTA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #5.
temperaturethe caller passed:temperature=0.0still triggered a retry.decode_batch_with_fallbacknow walks the same schedule as the one-window path. At each step it re-decodes only the segments that still fail, as one smaller batch. A single temperature means no fallback.needs_fallback) is shared by both paths instead of being duplicated.best_ofis still dropped in batched mode, now with a comment saying why:DecodingTaskonly supports it for a single segment.How was this tested?
pytest): 30 passedvayu audio.mp3)tests/test_temperature_fallback.pycovers:The three batched tests fail on
main.claude-reviewwill fail as on #12 (the repository'sCLAUDE_CODE_OAUTH_TOKENsecret, see this comment).🤖 Generated with Claude Code
https://claude.ai/code/session_01TMXYMqgLAykqRApmbRfpTA
Generated by Claude Code