Let the release workflow create the tag itself - #23
Merged
Merged
Conversation
Add a workflow_dispatch trigger: "Run workflow" on main tags the current commit as v<version from pyproject.toml> and creates the release, so a release no longer depends on someone pushing a tag. Tag pushes still work and are still checked against the package version. PyPI publishing now waits for the GitHub release, so a package is never published without its tag and release notes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TMXYMqgLAykqRApmbRfpTA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow-up to #22. The session that prepared 1.1.0 can push branches but not tags (its git access returns HTTP 403 for
refs/tags/*), so it couldn't start the tag-triggered release.workflow_dispatchtrigger torelease.yml. Run workflow onmaintags the current commit asv<version from pyproject.toml>, creates the GitHub release from that version's CHANGELOG section, and publishes to PyPI. A manual run from any other branch fails straight away.v*tag still works, and is still checked against the package version.How was this tested?
pytest): no Python changes; CI runs them anywayvayu audio.mp3)I ran the tag-resolution step from the workflow file locally in bash, for four cases:
maintag=v1.1.0v1.1.0tag=v1.1.0v9.9.9The YAML parses.
After merging, I'll start the workflow on
mainto publish 1.1.0. PyPI still needs the trusted publisher configured (ownerCodeWithBehnam, repovayu, workflowrelease.yml, environmentpypi).claude-reviewwill fail as on #12 (the repository'sCLAUDE_CODE_OAUTH_TOKENsecret, see this comment).🤖 Generated with Claude Code
https://claude.ai/code/session_01TMXYMqgLAykqRApmbRfpTA
Generated by Claude Code