Skip to content

security(codecs): cap pending GELF messages - #26301

Merged
pront merged 4 commits into
masterfrom
pront-gelf-pending-message-limit
Sep 8, 2026
Merged

security(codecs): cap pending GELF messages#26301
pront merged 4 commits into
masterfrom
pront-gelf-pending-message-limit

Conversation

@pront

@pront pront commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

Each incomplete chunked GELF message allocates message state and a timeout task. A configurable limit alone could still permit an unsafe number of pending messages.

Changes

  • Add a hard ceiling of 4,096 pending messages.
  • Keep pending_messages_limit available for choosing a lower ceiling.
  • Continue accepting chunks for messages that are already pending when the table is full.
  • Update generated component documentation and add a security changelog fragment.

References

Related: #26137

Stack: #26299 -> #26300 -> #26301 -> #26302

Vector configuration

Not applicable; the limit is exercised directly at the decoder boundary.

How did you test this PR?

Focused tests exercise default, raised, lowered, and saturated pending-message limits.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Before pushing, follow our pre-push guidance.
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.

@pront
pront requested review from a team as code owners September 3, 2026 17:26
@github-actions github-actions Bot added domain: external docs Anything related to Vector's external, public documentation docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. labels Sep 3, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T19:42:15.250959Z 899ece8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71780fe676

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs

@thomasqueirozb thomasqueirozb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock

Comment thread changelog.d/chunked_gelf_pending_messages_bounded.security.md Outdated
Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs
@github-actions github-actions Bot removed the docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. label Sep 8, 2026
@pront
pront added this pull request to the merge queue Sep 8, 2026
@pront
pront removed this pull request from the merge queue due to a manual request Sep 8, 2026
@pront
pront force-pushed the pront-gelf-pending-message-limit branch from 118b6b4 to 3e54fd8 Compare September 8, 2026 19:09
@pront
pront force-pushed the pront-gelf-pending-message-limit branch from 3e54fd8 to 279a767 Compare September 8, 2026 19:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 279a767c16

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs Outdated
Comment thread changelog.d/chunked_gelf_pending_messages_bounded.security.md Outdated
@pront
pront added this pull request to the merge queue Sep 8, 2026
Merged via the queue into master with commit 85b39fa Sep 8, 2026
105 checks passed
@pront
pront deleted the pront-gelf-pending-message-limit branch September 8, 2026 20:34
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain: external docs Anything related to Vector's external, public documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants