security(codecs): bound chunked GELF memory - #26137
Conversation
597e488 to
2db2e2b
Compare
c4244b3 to
76018e3
Compare
76018e3 to
556f752
Compare
556f752 to
2960a0a
Compare
0abddf6 to
7e26e03
Compare
7e26e03 to
e5723c1
Compare
e5723c1 to
2ac4a65
Compare
2ac4a65 to
8a27780
Compare
8a27780 to
1f093ad
Compare
1f093ad to
71fbd8a
Compare
|
@codex review |
This comment was marked as outdated.
This comment was marked as outdated.
71fbd8a to
b208ebf
Compare
b208ebf to
045c360
Compare
Merge commits are not allowed on this repository
045c360 to
567083a
Compare
567083a to
f43b72c
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f43b72ce22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5bbcf19ca9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2bd9eb2a69
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Motivation
The
chunked_gelfdecoder retains incomplete messages until they complete or time out. Neither the pending-message count nor aggregate buffered payload had an unconditional bound, so an unauthenticated sender could exhaust memory using unique message IDs it never completes.The replacement stack separates the assembly cleanup, single-chunk correctness, pending-message count ceiling, and aggregate payload ceiling so each invariant can be reviewed independently.
Changes
References
Replaced by: #26299, #26300, #26301, #26302
Vector configuration
How did you test this PR?
Focused chunked GELF tests cover assembly, buffer ownership, both limits, and accounting across completion, timeout, rejection, and saturation.
Does this PR include user facing changes?
no-changeloglabel to this PR.Contributor Guidelines
The repository contributor and pre-push guidance was followed.