Skip to content

security(codecs): bound chunked GELF memory - #26137

Closed
pront wants to merge 4 commits into
masterfrom
pront-chunked-gelf-pending-message-dos
Closed

security(codecs): bound chunked GELF memory#26137
pront wants to merge 4 commits into
masterfrom
pront-chunked-gelf-pending-message-dos

Conversation

@pront

@pront pront commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

Superseded by the smaller review stack #26299 -> #26300 -> #26301 -> #26302.

Motivation

The chunked_gelf decoder retains incomplete messages until they complete or time out. Neither the pending-message count nor aggregate buffered payload had an unconditional bound, so an unauthenticated sender could exhaust memory using unique message IDs it never completes.

The replacement stack separates the assembly cleanup, single-chunk correctness, pending-message count ceiling, and aggregate payload ceiling so each invariant can be reviewed independently.

Changes

References

Replaced by: #26299, #26300, #26301, #26302

Vector configuration

sources:
  graylog:
    type: socket
    mode: udp
    address: 0.0.0.0:12201
    framing:
      method: chunked_gelf
    decoding:
      codec: gelf

sinks:
  out:
    type: blackhole
    inputs:
      - graylog

How did you test this PR?

Focused chunked GELF tests cover assembly, buffer ownership, both limits, and accounting across completion, timeout, rejection, and saturation.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

The repository contributor and pre-push guidance was followed.

@github-actions github-actions Bot added docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation labels Aug 18, 2026
@pront
pront marked this pull request as ready for review August 18, 2026 13:19
@pront
pront requested review from a team as code owners August 18, 2026 13:19
@pront pront changed the title security(codecs): bound chunked_gelf buffered state by default security(codecs): set default chunked_gelf limits Aug 18, 2026
@pront
pront enabled auto-merge August 18, 2026 16:37
chatgpt-codex-connector[bot]

This comment was marked as outdated.

chatgpt-codex-connector[bot]

This comment was marked as outdated.

chatgpt-codex-connector[bot]

This comment was marked as outdated.

chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 597e488 to 2db2e2b Compare August 19, 2026 19:03
@pront pront changed the title security(codecs): set default chunked_gelf limits security(codecs): bound chunked_gelf decoder memory Aug 19, 2026
chatgpt-codex-connector[bot]

This comment was marked as outdated.

chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch 2 times, most recently from c4244b3 to 76018e3 Compare August 19, 2026 22:25
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 76018e3 to 556f752 Compare August 19, 2026 22:35
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 556f752 to 2960a0a Compare August 20, 2026 00:14
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch 2 times, most recently from 0abddf6 to 7e26e03 Compare August 20, 2026 00:31
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 7e26e03 to e5723c1 Compare August 20, 2026 00:42
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from e5723c1 to 2ac4a65 Compare August 20, 2026 00:50
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 2ac4a65 to 8a27780 Compare August 20, 2026 00:54
@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 8a27780 to 1f093ad Compare August 20, 2026 00:57
chatgpt-codex-connector[bot]

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 1f093ad to 71fbd8a Compare August 20, 2026 01:04
@pront

pront commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

This comment was marked as outdated.

@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 71fbd8a to b208ebf Compare August 20, 2026 13:26
@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from b208ebf to 045c360 Compare August 20, 2026 14:17
@pront
pront changed the base branch from master to pront-chunked-gelf-preexisting-fixes August 20, 2026 14:18
auto-merge was automatically disabled August 20, 2026 14:18

Merge commits are not allowed on this repository

Base automatically changed from pront-chunked-gelf-preexisting-fixes to master August 24, 2026 14:35
@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 045c360 to 567083a Compare August 24, 2026 19:20
@pront
pront force-pushed the pront-chunked-gelf-pending-message-dos branch from 567083a to f43b72c Compare September 3, 2026 13:46
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T16:21:16.853321Z 2bd9eb2 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pront pront changed the title security(codecs): bound chunked_gelf decoder memory security(codecs): bound chunked GELF memory Sep 3, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f43b72ce22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs
Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs
Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5bbcf19ca9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2bd9eb2a69

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread lib/codecs/src/decoding/framing/chunked_gelf.rs
@pront

pront commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Superseded by the smaller stacked PRs #26299, #26300, #26301, and #26302. The open review finding was fixed in #26299 and carried through the stack.

@pront pront closed this Sep 3, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs review on hold The documentation team reviews PRs only after a PR is approved by the COSE team. domain: external docs Anything related to Vector's external, public documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant