Skip to content

fix(codecs): handle single-chunk GELF messages directly - #26300

Merged
pront merged 6 commits into
masterfrom
pront-gelf-single-chunk
Sep 8, 2026
Merged

fix(codecs): handle single-chunk GELF messages directly#26300
pront merged 6 commits into
masterfrom
pront-gelf-single-chunk

Conversation

@pront

@pront pront commented Sep 3, 2026

Copy link
Copy Markdown
Member

Summary

Motivation

A one-chunk GELF message is already complete, but the decoder sent it through the pending-message path. That created unnecessary state and made message-ID ownership harder to enforce.

Changes

  • Decode one-chunk messages without creating pending state or a timeout task.
  • Detach returned and retained payloads from the decoder input buffer.
  • Reject a one-chunk message that reuses the ID of a pending multi-chunk message.

References

Related: #26137

Stack: #26299 -> #26300 -> #26301 -> #26302

Vector configuration

Not applicable; the decoder behavior is exercised directly.

How did you test this PR?

Focused tests exercise source-buffer ownership and pending message-ID reuse.

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

Contributor Guidelines

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Before pushing, follow our pre-push guidance.
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.

@pront
pront requested a review from a team as a code owner September 3, 2026 17:26
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-03T19:00:16.433491Z d750fd3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Sep 3, 2026
@pront
pront added this pull request to the merge queue Sep 8, 2026
Base automatically changed from pront-gelf-final-chunk-assembly to master September 8, 2026 15:31
Merged via the queue into master with commit 5e13c61 Sep 8, 2026
119 of 140 checks passed
@pront
pront deleted the pront-gelf-single-chunk branch September 8, 2026 15:49
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants